[GitHub] csantanapr commented on a change in pull request #3335: Allow container tests to run without a proxy.

[GitBox <gi...@apache.org>]

csantanapr commented on a change in pull request #3335: Allow container tests to run without a proxy.
URL: https://github.com/apache/incubator-openwhisk/pull/3335#discussion_r170381377
 
 

 ##########
 File path: tests/src/test/scala/actionContainers/ActionContainer.scala
 ##########
 @@ -135,19 +135,32 @@ object ActionContainer {
       case (k, v) => s"-e ${k}=${v}"
     } mkString (" ")
 
-    // We create the container...
-    val runOut = awaitDocker(s"run --name $name $envArgs -d $imageName", 10 seconds)
-    assert(runOut._1 == 0, "'docker run' did not exit with 0: " + runOut)
+    // We create the container... and find out its IP address...
+    def createContainer(portFwd: Option[Int] = None) = {
+      val runOut = awaitDocker(
+        s"run ${portFwd.map(p => s"-p $p:8080").getOrElse("")} --name $name $envArgs -d $imageName",
 
 Review comment:
   @rabbah I thought we try at one point to remove the proxy but we ran into trouble, and that's we have the proxy.
   
   can't recall now why didn't push forward for a solution.
   
   But this would be great if we can get rid off the proxy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services