You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/10/05 22:54:36 UTC
Review Request 39017: RegistryClient refactor: encapsulated Manifest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Wrapped Manifest with ManifestResponse. getManifest returns the encapsulated ManifestResponse.
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185
src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd
src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39017/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39017: RegistryClient refactor: changed Manifest
struct
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 11:23 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Repository: mesos
Description
-------
Added factory method.
Removed digest.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
Diff: https://reviews.apache.org/r/39017/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39017: RegistryClient refactor: changed Manifest
struct
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
-----------------------------------------------------------
(Updated Nov. 1, 2015, 3:33 p.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
RegistryClient refactor: changed Manifest struct
Repository: mesos
Description (updated)
-------
Added factory method.
Removed digest.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp ad57d8592c5f9df5115b575855ed2e99a0597359
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c
Diff: https://reviews.apache.org/r/39017/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39017: RegistryClient refactor: encapsulated
Manifest
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 7:16 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Repository: mesos
Description
-------
Wrapped Manifest with ManifestResponse. getManifest returns the encapsulated ManifestResponse.
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.hpp fdb68b675582f603ffb3e96f31c1c9405e238567
src/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39017/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 39017: RegistryClient refactor: encapsulated
Manifest
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39017/
-----------------------------------------------------------
(Updated Oct. 7, 2015, 12:41 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased after updating patches.
Repository: mesos
Description
-------
Wrapped Manifest with ManifestResponse. getManifest returns the encapsulated ManifestResponse.
Diffs (updated)
-----
src/slave/containerizer/provisioner/docker/registry_client.hpp fdb68b675582f603ffb3e96f31c1c9405e238567
src/slave/containerizer/provisioner/docker/registry_client.cpp 4931ae8869a697b1e9d8d4cbc0a871e7cd506285
src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/39017/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese