You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/10/05 21:56:32 UTC

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4636

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................

KUDU-1669. Java client tests leak orphan processes (part 2)

In some cases we weren't waiting for the processes to actually finish.

Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
1 file changed, 19 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/4636/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

PS1, Line 359: catch (InterruptedException ex) {
             :       // We still need to finish cleaning up.
             :     }
This isn't quite correct; if we are interrupted (not that we should be, but Java forces us to handle this case anyway) after waiting for the first master, we should still destroy/remove the remaining processes. Meaning, we should try/catch around each destroyAndWaitForProcess(...) call, and proceed to remove() that process either way.


Line 363:       thread.interrupt();
It would be nice to avoid using thread interruption here too. I wonder: if we kill and wait for all of the processes associated with the input printers, shouldn't the input printers exit naturally, without the need for explicit interruption? Won't BufferedReader.readLine() throw an EOFException or some such? 

Also, we should join() on these threads exiting.


-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4636

to look at the new patch set (#2).

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................

KUDU-1669. Java client tests leak orphan processes (part 2)

In some cases we weren't waiting for the processes to actually finish.

Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
1 file changed, 23 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/4636/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

PS1, Line 359: catch (InterruptedException ex) {
             :       // We still need to finish cleaning up.
             :     }
> This isn't quite correct; if we are interrupted (not that we should be, but
I guess if we really really want to be clean then yeah we'll have to wrap those individually. As you can see, I didn't want to go there.


Line 363:       thread.interrupt();
> It would be nice to avoid using thread interruption here too. I wonder: if 
Checking...


-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 363:       }
> Cool, so this worked out? Might want to add a comment explaining what's goi
Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4636

to look at the new patch set (#3).

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................

KUDU-1669. Java client tests leak orphan processes (part 2)

In some cases we weren't waiting for the processes to actually finish.

Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
1 file changed, 27 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/4636/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


KUDU-1669. Java client tests leak orphan processes (part 2)

In some cases we weren't waiting for the processes to actually finish.

Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Reviewed-on: http://gerrit.cloudera.org:8080/4636
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
1 file changed, 27 insertions(+), 9 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

PS1, Line 359: catch (InterruptedException ex) {
             :       // We still need to finish cleaning up.
             :     }
> I guess if we really really want to be clean then yeah we'll have to wrap t
Yeah, but I think we should. It's a tiny headache that makes this code robust should thread interruptions sneak back in via another test.


-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1669. Java client tests leak orphan processes (part 2)

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: KUDU-1669. Java client tests leak orphan processes (part 2)
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4636/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 363:       }
> Checking...
Cool, so this worked out? Might want to add a comment explaining what's going on (that this cleanup depends on first waiting for all the processes to exit), to prevent someone from changing the order of this in the future and messing it up.


-- 
To view, visit http://gerrit.cloudera.org:8080/4636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d33ca2339048a51acfbb35f5b71e827d3a47f7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes