You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/05/03 23:54:48 UTC

[jira] [Created] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Gregory Chanan created HBASE-5933:
-------------------------------------

             Summary: Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
                 Key: HBASE-5933
                 URL: https://issues.apache.org/jira/browse/HBASE-5933
             Project: HBase
          Issue Type: Task
          Components: ipc
    Affects Versions: 0.96.0
            Reporter: Gregory Chanan
            Assignee: Gregory Chanan
            Priority: Minor


>From Stack's comments on HBASE-5444:
"We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Chanan updated HBASE-5933:
----------------------------------

    Status: Patch Available  (was: Open)
    
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Chanan updated HBASE-5933:
----------------------------------

    Attachment: HBASE-5933-v3.patch
    
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933-v3.patch, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398960#comment-13398960 ] 

Gregory Chanan commented on HBASE-5933:
---------------------------------------

It looks like reviewboard isn't posting to the JIRA anymore, so here's the review request:
https://reviews.apache.org/r/5415/
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397026#comment-13397026 ] 

Gregory Chanan commented on HBASE-5933:
---------------------------------------

Tests appear to be okay:
TestSplitLogManager seems to be flaky, it passed when I ran it.
TestAtomicOperation failed even without this patch applied.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400933#comment-13400933 ] 

Hudson commented on HBASE-5933:
-------------------------------

Integrated in HBase-TRUNK #3071 (See [https://builds.apache.org/job/HBase-TRUNK/3071/])
    HBASE-5933 Add RegionLoad.java (Gregory) (Revision 1353743)
HBASE-5933 Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus, remove HServerLoad.java
           (Gregory) (Revision 1353742)
HBASE-5933 Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus (Gregory) (Revision 1353740)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/RegionLoad.java

tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HServerLoad.java

tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
* /hbase/trunk/hbase-server/src/main/protobuf/hbase.proto
* /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java

                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933-v3.patch, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Ted Yu updated HBASE-5933:
----------------------------------

    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed
    
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399783#comment-13399783 ] 

Gregory Chanan commented on HBASE-5933:
---------------------------------------

Thanks for the reviews, Ted and Elliot.

New version is up on review board.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Ted Yu updated HBASE-5933:
----------------------------------

    Attachment: 5933-v2.txt

Patch from Gregory.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: 5933-v2.txt, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400779#comment-13400779 ] 

Hadoop QA commented on HBASE-5933:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12533346/HBASE-5933-v3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 15 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2250//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2250//console

This message is automatically generated.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933-v3.patch, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398983#comment-13398983 ] 

Zhihong Ted Yu commented on HBASE-5933:
---------------------------------------

I put a few comments on review board.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396956#comment-13396956 ] 

Hadoop QA commented on HBASE-5933:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532584/HBASE-5933.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 15 new or modified tests.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestAtomicOperation
                  org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2190//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2190//console

This message is automatically generated.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398988#comment-13398988 ] 

Elliott Clark commented on HBASE-5933:
--------------------------------------

I posted a few as well.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Chanan updated HBASE-5933:
----------------------------------

    Attachment: HBASE-5933.patch

patch that matches reviewboard.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>         Attachments: HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400902#comment-13400902 ] 

Zhihong Ted Yu commented on HBASE-5933:
---------------------------------------

Integrated to trunk.

Thanks for the patch, Gregory.

Thanks for the review, Elliot.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933-v3.patch, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401045#comment-13401045 ] 

Hudson commented on HBASE-5933:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #68 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/68/])
    HBASE-5933 Add RegionLoad.java (Gregory) (Revision 1353743)
HBASE-5933 Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus, remove HServerLoad.java
           (Gregory) (Revision 1353742)
HBASE-5933 Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus (Gregory) (Revision 1353740)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/RegionLoad.java

tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HServerLoad.java

tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
* /hbase/trunk/hbase-server/src/main/protobuf/hbase.proto
* /hbase/trunk/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java

                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933-v3.patch, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Ted Yu updated HBASE-5933:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933-v3.patch, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5933) Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399959#comment-13399959 ] 

Zhihong Ted Yu commented on HBASE-5933:
---------------------------------------

The reason Hadoop QA didn't post back was this:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java:[47,30] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java:[34,30] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java:[196,21] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.ServerLoad
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/target/generated-sources/java/org/apache/hadoop/hbase/generated/master/table_jsp.java:[14,30] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[29,30] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[112,22] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[642,35] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java:[40,30] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java:[35,30] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: package org.apache.hadoop.hbase
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java:[80,37] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.avro.AvroUtil
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java:[197,16] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.ServerLoad
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java:[198,26] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.ServerLoad
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java:[200,6] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.ServerLoad
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java:[200,34] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.ServerLoad
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/target/generated-sources/java/org/apache/hadoop/hbase/generated/master/table_jsp.java:[197,20] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.generated.master.table_jsp
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[112,62] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[321,25] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[614,8] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:[623,35] inconvertible types
[ERROR] found   : <nulltype>
[ERROR] required: long
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java:[88,13] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.rest.StorageClusterStatusResource
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java:[99,15] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.avro.AvroUtil
[ERROR] 
[ERROR] /home/hduser/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java:[104,11] cannot find symbol
[ERROR] symbol  : class RegionLoad
[ERROR] location: class org.apache.hadoop.hbase.avro.AvroUtil
{code}
Please fix the compilation error and attach the new patch to this JIRA.
                
> Hide HBaseProtos.ServerLoad and HBaseProtos.RegionLoad from ClusterStatus
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5933
>                 URL: https://issues.apache.org/jira/browse/HBASE-5933
>             Project: HBase
>          Issue Type: Task
>          Components: ipc
>    Affects Versions: 0.96.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 5933-v2.txt, HBASE-5933.patch
>
>
> From Stack's comments on HBASE-5444:
> "We need this import?  Its for cp.  Thats ok I'd say.... One day we can hide that too.."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira