You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Ernie Rael (Jira)" <ji...@apache.org> on 2020/02/19 03:51:00 UTC

[jira] [Created] (NETBEANS-3898) ModuleList.doScanNetBeansOrgSources descends into .git/.hg

Ernie Rael created NETBEANS-3898:
------------------------------------

             Summary: ModuleList.doScanNetBeansOrgSources descends into .git/.hg
                 Key: NETBEANS-3898
                 URL: https://issues.apache.org/jira/browse/NETBEANS-3898
             Project: NetBeans
          Issue Type: Bug
          Components: apisupport - Project
            Reporter: Ernie Rael


 org.netbeans.modules.apisupport.project.universe.ModuleList.doScanNetBeansOrgSources produces LOG entries like: 
{quote}INFO...: exhaustive scan of F:\repos\netbeans\.hg\cache
 INFO...: exhaustive scan of F:\repos\netbeans\.hg\git
 ...
{quote}
Which come because of stuff after the following code, ("kids" is directories in <repo>/netebeans)
{code:java}
        for (File kid : kids) {
            if (!kid.isDirectory()) {
                continue;
            }
            String name = kid.getName();
            if (EXCLUDED_DIR_NAMES.contains(name)) {
                // #61579: known to not be project dirs, so skip to save time.
                continue;
            }
{code}
Can save even more time by staying out of the repo data. Two possible solutions
 * Add ".git" and ".hg" to EXCLUDED_DIR_NAMES
 * Skip anything that starts with "."

Comments? I'm inclined towards the second, skip anything that's hidden.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists