You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@myfaces.apache.org by Adam Winer <aw...@gmail.com> on 2007/09/05 03:48:14 UTC
Re: [TRINIDAD] - IMPORTANT - Custom Skin Developers
The old parameter was "trinidadinternal", and therefore was
never officially supported. If we were changing from one
supported name to another, I'd agree that we should keep the
old name around, but supporting backwards compatibility
for anything "trinidadinternal" is a precedent I don't think we
should set...
-- Adam
On 8/31/07, Martin Marinschek <ma...@gmail.com> wrote:
>
> Hi Danny,
>
> eventually we could additionally support also the old name for the
> configuration parameter, and only phase this out in a major release?
>
> regards,
>
> Martin
>
> On 8/28/07, Danny Robinson <da...@gmail.com> wrote:
> > In the hope of pre-empting some emails, be aware that the trunk has
> switched
> > to now use the following config setting for disabling skin compression.
> >
> > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > became
> > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> >
> > The docs and release notes in trunk also mention this.
> >
> > Thanks,
> >
> > Danny
> > --
> > Chordiant Software Inc.
> > www.chordiant.com
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
Re: [TRINIDAD] - IMPORTANT - Custom Skin Developers
Posted by Matt Cooper <ma...@gmail.com>.
Hey guys,
Here's my thinking... Everything that contains "trinidadinternal" in its
name is not supported as an external API. By definition it is subject to
change without notice. If something is internal and valuable as a supported
API we are doing the right thing by exposing it as a public API. I am quite
happy that we now have a public config param to disable content compression
in the skins. However, I feel that supporting the old trinidadinternal
config param will set a precedent for supporting things that are not
considered to be ready or designed for public consumption and potentially
misuse of the system.
That said, I could be convinced to have a short grace period for this
parameter since I think it has been recommended for use on the mailing lists
though I think we (myself included) should be careful about making
recommendations to use internal things going forward.
Regards,
Matt
On 9/7/07, Martin Marinschek <ma...@gmail.com> wrote:
>
> That's what I suggested, and Adam and Matt disagreed on. At least I
> thought so ;)
>
> One more hint why I think this would be appropriate: it shouldn't have
> been a trinidadinternal parameter in the beginning, so I'd think we
> shouldn't force users to take action on fixing a mistake we've been
> making. However, I do also see the added value of a consistent set of
> configuration parameters which are the same everywhere, so I stop
> discussing right now ;)
>
> regards,
>
> Martin
>
> On 9/8/07, Andrew Robinson <an...@gmail.com> wrote:
> > Why not keep the old one and the new one and just mark the old one as
> > deprecated for the next release? If both are set, the new one could
> > take precedence.
> >
> > On 9/7/07, Martin Marinschek <ma...@gmail.com> wrote:
> > > Hi Matt, Adam,
> > >
> > > well, it's your call - but there are quite a few people out there who
> > > will have used this parameter already. Have fun answering their mails
> > > ;))
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > On 9/5/07, Matt Cooper <ma...@gmail.com> wrote:
> > > > I agree with Adam.
> > > >
> > > >
> > > > On 9/4/07, Adam Winer <aw...@gmail.com> wrote:
> > > > > The old parameter was "trinidadinternal", and therefore was
> > > > > never officially supported. If we were changing from one
> > > > > supported name to another, I'd agree that we should keep the
> > > > > old name around, but supporting backwards compatibility
> > > > > for anything "trinidadinternal" is a precedent I don't think we
> > > > > should set...
> > > > >
> > > > > -- Adam
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 8/31/07, Martin Marinschek < martin.marinschek@gmail.com>
> wrote:
> > > > > > Hi Danny,
> > > > > >
> > > > > > eventually we could additionally support also the old name for
> the
> > > > > > configuration parameter, and only phase this out in a major
> release?
> > > > > >
> > > > > > regards,
> > > > > >
> > > > > > Martin
> > > > > >
> > > > > > On 8/28/07, Danny Robinson < dannyjrobinson@gmail.com> wrote:
> > > > > > > In the hope of pre-empting some emails, be aware that the
> trunk has
> > > > switched
> > > > > > > to now use the following config setting for disabling skin
> > > > compression.
> > > > > > >
> > > > > > >
> > > > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > > > > > became
> > > > > > >
> > > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > > > > > >
> > > > > > > The docs and release notes in trunk also mention this.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Danny
> > > > > > > --
> > > > > > > Chordiant Software Inc.
> > > > > > > www.chordiant.com
> > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > > http://www.irian.at
> > > > > >
> > > > > > Your JSF powerhouse -
> > > > > > JSF Consulting, Development and
> > > > > > Courses in English and German
> > > > > >
> > > > > > Professional Support for Apache MyFaces
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
Re: [TRINIDAD] - IMPORTANT - Custom Skin Developers
Posted by Martin Marinschek <ma...@gmail.com>.
That's what I suggested, and Adam and Matt disagreed on. At least I
thought so ;)
One more hint why I think this would be appropriate: it shouldn't have
been a trinidadinternal parameter in the beginning, so I'd think we
shouldn't force users to take action on fixing a mistake we've been
making. However, I do also see the added value of a consistent set of
configuration parameters which are the same everywhere, so I stop
discussing right now ;)
regards,
Martin
On 9/8/07, Andrew Robinson <an...@gmail.com> wrote:
> Why not keep the old one and the new one and just mark the old one as
> deprecated for the next release? If both are set, the new one could
> take precedence.
>
> On 9/7/07, Martin Marinschek <ma...@gmail.com> wrote:
> > Hi Matt, Adam,
> >
> > well, it's your call - but there are quite a few people out there who
> > will have used this parameter already. Have fun answering their mails
> > ;))
> >
> > regards,
> >
> > Martin
> >
> > On 9/5/07, Matt Cooper <ma...@gmail.com> wrote:
> > > I agree with Adam.
> > >
> > >
> > > On 9/4/07, Adam Winer <aw...@gmail.com> wrote:
> > > > The old parameter was "trinidadinternal", and therefore was
> > > > never officially supported. If we were changing from one
> > > > supported name to another, I'd agree that we should keep the
> > > > old name around, but supporting backwards compatibility
> > > > for anything "trinidadinternal" is a precedent I don't think we
> > > > should set...
> > > >
> > > > -- Adam
> > > >
> > > >
> > > >
> > > >
> > > > On 8/31/07, Martin Marinschek < martin.marinschek@gmail.com> wrote:
> > > > > Hi Danny,
> > > > >
> > > > > eventually we could additionally support also the old name for the
> > > > > configuration parameter, and only phase this out in a major release?
> > > > >
> > > > > regards,
> > > > >
> > > > > Martin
> > > > >
> > > > > On 8/28/07, Danny Robinson < dannyjrobinson@gmail.com> wrote:
> > > > > > In the hope of pre-empting some emails, be aware that the trunk has
> > > switched
> > > > > > to now use the following config setting for disabling skin
> > > compression.
> > > > > >
> > > > > >
> > > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > > > > became
> > > > > >
> > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > > > > >
> > > > > > The docs and release notes in trunk also mention this.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Danny
> > > > > > --
> > > > > > Chordiant Software Inc.
> > > > > > www.chordiant.com
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > http://www.irian.at
> > > > >
> > > > > Your JSF powerhouse -
> > > > > JSF Consulting, Development and
> > > > > Courses in English and German
> > > > >
> > > > > Professional Support for Apache MyFaces
> > > > >
> > > >
> > > >
> > >
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: [TRINIDAD] - IMPORTANT - Custom Skin Developers
Posted by Andrew Robinson <an...@gmail.com>.
Why not keep the old one and the new one and just mark the old one as
deprecated for the next release? If both are set, the new one could
take precedence.
On 9/7/07, Martin Marinschek <ma...@gmail.com> wrote:
> Hi Matt, Adam,
>
> well, it's your call - but there are quite a few people out there who
> will have used this parameter already. Have fun answering their mails
> ;))
>
> regards,
>
> Martin
>
> On 9/5/07, Matt Cooper <ma...@gmail.com> wrote:
> > I agree with Adam.
> >
> >
> > On 9/4/07, Adam Winer <aw...@gmail.com> wrote:
> > > The old parameter was "trinidadinternal", and therefore was
> > > never officially supported. If we were changing from one
> > > supported name to another, I'd agree that we should keep the
> > > old name around, but supporting backwards compatibility
> > > for anything "trinidadinternal" is a precedent I don't think we
> > > should set...
> > >
> > > -- Adam
> > >
> > >
> > >
> > >
> > > On 8/31/07, Martin Marinschek < martin.marinschek@gmail.com> wrote:
> > > > Hi Danny,
> > > >
> > > > eventually we could additionally support also the old name for the
> > > > configuration parameter, and only phase this out in a major release?
> > > >
> > > > regards,
> > > >
> > > > Martin
> > > >
> > > > On 8/28/07, Danny Robinson < dannyjrobinson@gmail.com> wrote:
> > > > > In the hope of pre-empting some emails, be aware that the trunk has
> > switched
> > > > > to now use the following config setting for disabling skin
> > compression.
> > > > >
> > > > >
> > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > > > became
> > > > >
> > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > > > >
> > > > > The docs and release notes in trunk also mention this.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Danny
> > > > > --
> > > > > Chordiant Software Inc.
> > > > > www.chordiant.com
> > > >
> > > >
> > > > --
> > > >
> > > > http://www.irian.at
> > > >
> > > > Your JSF powerhouse -
> > > > JSF Consulting, Development and
> > > > Courses in English and German
> > > >
> > > > Professional Support for Apache MyFaces
> > > >
> > >
> > >
> >
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
Re: [TRINIDAD] - IMPORTANT - Custom Skin Developers
Posted by Martin Marinschek <ma...@gmail.com>.
Hi Matt, Adam,
well, it's your call - but there are quite a few people out there who
will have used this parameter already. Have fun answering their mails
;))
regards,
Martin
On 9/5/07, Matt Cooper <ma...@gmail.com> wrote:
> I agree with Adam.
>
>
> On 9/4/07, Adam Winer <aw...@gmail.com> wrote:
> > The old parameter was "trinidadinternal", and therefore was
> > never officially supported. If we were changing from one
> > supported name to another, I'd agree that we should keep the
> > old name around, but supporting backwards compatibility
> > for anything "trinidadinternal" is a precedent I don't think we
> > should set...
> >
> > -- Adam
> >
> >
> >
> >
> > On 8/31/07, Martin Marinschek < martin.marinschek@gmail.com> wrote:
> > > Hi Danny,
> > >
> > > eventually we could additionally support also the old name for the
> > > configuration parameter, and only phase this out in a major release?
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > On 8/28/07, Danny Robinson < dannyjrobinson@gmail.com> wrote:
> > > > In the hope of pre-empting some emails, be aware that the trunk has
> switched
> > > > to now use the following config setting for disabling skin
> compression.
> > > >
> > > >
> org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > > became
> > > >
> org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > > >
> > > > The docs and release notes in trunk also mention this.
> > > >
> > > > Thanks,
> > > >
> > > > Danny
> > > > --
> > > > Chordiant Software Inc.
> > > > www.chordiant.com
> > >
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
> >
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
Re: [TRINIDAD] - IMPORTANT - Custom Skin Developers
Posted by Matt Cooper <ma...@gmail.com>.
I agree with Adam.
On 9/4/07, Adam Winer <aw...@gmail.com> wrote:
>
> The old parameter was "trinidadinternal", and therefore was
> never officially supported. If we were changing from one
> supported name to another, I'd agree that we should keep the
> old name around, but supporting backwards compatibility
> for anything "trinidadinternal" is a precedent I don't think we
> should set...
>
> -- Adam
>
>
> On 8/31/07, Martin Marinschek < martin.marinschek@gmail.com> wrote:
> >
> > Hi Danny,
> >
> > eventually we could additionally support also the old name for the
> > configuration parameter, and only phase this out in a major release?
> >
> > regards,
> >
> > Martin
> >
> > On 8/28/07, Danny Robinson < dannyjrobinson@gmail.com> wrote:
> > > In the hope of pre-empting some emails, be aware that the trunk has
> > switched
> > > to now use the following config setting for disabling skin
> > compression.
> > >
> > > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION
> > > became
> > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION
> > >
> > > The docs and release notes in trunk also mention this.
> > >
> > > Thanks,
> > >
> > > Danny
> > > --
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>