You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/28 20:27:00 UTC
[GitHub] [pulsar] vzhikserg opened a new pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
vzhikserg opened a new pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835
Fixes #5215 #4601 #5215
### Motivation
Right now, the number of supported JDBC connectors is rather limited. There are a couple of open issues related to the missing connectors.
### Modifications
As a base for this pull request, I took the [changes](https://github.com/apache/pulsar/pull/5624) from @huangdx0726 Unfortunately, I was not able to reach him to merge my changes to his branch, so I created a new one.
The main modification is a split of one JDBC module into a bunch of them. One module serves as a core and provide the main logic of the connector. Other modules are real connectors and add only an appropriate JDBC driver.
### Verifying this change
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
- The default values of configurations: (yes)
- Anything that affects deployment: (yes / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs / JavaDocs)
I would like to confirm that this is the right way and after that, I can change existing documentation for the MySQL and SQLite connectors, and add docs for the newly added connectors.
One more question is related to the MySQL connector and the #6656 Does it mean that we need to remove the MySQL connector?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835#issuecomment-628904099
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835#issuecomment-629057491
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835#issuecomment-630428739
@sijie the pull request is ready for the final review.
The MySQL connector was removed from the distribution. Documentation on how to use the MySQL connector was substituted with the Postgres connector. The integration tests were also updated to use Postgres.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835#issuecomment-622926218
@sijie could you please comment on this pull request? Do you think that it is a right approach? Shall I continue working on it and change/add docs? Did I miss something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835#issuecomment-626624891
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #6835: [Issue 5215,4601,5215][pulsar-io] Add jdbc sinks: postgres, mariadb, clickhouse
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6835:
URL: https://github.com/apache/pulsar/pull/6835#issuecomment-625083975
@vzhikserg I like the approach. This works out very well.
Just one minor comment - I don't think we can bundle MySQL in the release anymore because of the license issue. It might be worth removing that one from this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org