You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/09/13 03:49:40 UTC
[PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
kou opened a new pull request, #44097:
URL: https://github.com/apache/arrow/pull/44097
### Rationale for this change
Boost.Process doesn't work with Emscripten. So we can't build `arrow::util::Process`.
### What changes are included in this PR?
Don't use Boost.Process with Emscripten. `arrow::util::Process` returns `Status::NotImplemented` with Emscripten.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44097:
URL: https://github.com/apache/arrow/pull/44097#issuecomment-2350870617
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62060ab55be2dc811e5abf0c5aba9834d3056ee1.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/30140505455) has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #44097:
URL: https://github.com/apache/arrow/pull/44097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44097:
URL: https://github.com/apache/arrow/pull/44097#issuecomment-2348031963
+1
This `test-conda-python-emscripten` failure is unrelated:
https://github.com/ursacomputing/crossbow/actions/runs/10842738518/job/30088799844#step:7:8843
```text
==================================== ERRORS ====================================
____________ ERROR at setup of test_column_chunk_key_value_metadata ____________
@pytest.fixture(scope='module')
def parquet_test_datadir():
result = os.environ.get('PARQUET_TEST_DATA')
if not result:
> raise RuntimeError('Please point the PARQUET_TEST_DATA environment '
'variable to the test data directory')
E RuntimeError: Please point the PARQUET_TEST_DATA environment variable to the test data directory
/lib/python3.12/site-packages/pyarrow/tests/parquet/conftest.py:35: RuntimeError
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44097:
URL: https://github.com/apache/arrow/pull/44097#issuecomment-2347980388
:warning: GitHub issue #44096 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44097:
URL: https://github.com/apache/arrow/pull/44097#issuecomment-2347980314
@github-actions crossbow submit *-emscripten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44097:
URL: https://github.com/apache/arrow/pull/44097#issuecomment-2347982038
Revision: ad112ada2b54846c25cd97e642eaf40b0a76e04d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0be59ac65c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0be59ac65c)
|Task|Status|
|----|------|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10842738518/job/30088799844)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/10842738514/job/30088799845)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org