You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by bl...@apache.org on 2016/02/03 21:45:36 UTC
parquet-mr git commit: PARQUET-415: Fix ByteBuffer Binary
serialization.
Repository: parquet-mr
Updated Branches:
refs/heads/master 06a468995 -> 0a711ebce
PARQUET-415: Fix ByteBuffer Binary serialization.
This also adds a test to validate that serialization works for all
Binary objects that are already test cases.
Author: Ryan Blue <bl...@apache.org>
Closes #305 from rdblue/PARQUET-415-fix-bytebuffer-binary-serialization and squashes the following commits:
4e75d54 [Ryan Blue] PARQUET-415: Fix ByteBuffer Binary serialization.
Project: http://git-wip-us.apache.org/repos/asf/parquet-mr/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-mr/commit/0a711ebc
Tree: http://git-wip-us.apache.org/repos/asf/parquet-mr/tree/0a711ebc
Diff: http://git-wip-us.apache.org/repos/asf/parquet-mr/diff/0a711ebc
Branch: refs/heads/master
Commit: 0a711ebcec7d32b66ab3c90b2a1f48681201e557
Parents: 06a4689
Author: Ryan Blue <bl...@apache.org>
Authored: Wed Feb 3 12:45:27 2016 -0800
Committer: Ryan Blue <bl...@apache.org>
Committed: Wed Feb 3 12:45:27 2016 -0800
----------------------------------------------------------------------
.../java/org/apache/parquet/io/api/Binary.java | 8 +++++---
.../org/apache/parquet/io/api/TestBinary.java | 21 ++++++++++++++++++++
2 files changed, 26 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/0a711ebc/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
----------------------------------------------------------------------
diff --git a/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java b/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
index ff833ec..4a167bd 100644
--- a/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
+++ b/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
@@ -355,9 +355,9 @@ abstract public class Binary implements Comparable<Binary>, Serializable {
private static class ByteBufferBackedBinary extends Binary {
private ByteBuffer value;
- private byte[] cachedBytes;
- private final int offset;
- private final int length;
+ private transient byte[] cachedBytes;
+ private int offset;
+ private int length;
public ByteBufferBackedBinary(ByteBuffer value, int offset, int length, boolean isBackingBytesReused) {
this.value = value;
@@ -502,6 +502,8 @@ abstract public class Binary implements Comparable<Binary>, Serializable {
byte[] bytes = new byte[length];
in.readFully(bytes, 0, length);
this.value = ByteBuffer.wrap(bytes);
+ this.offset = 0;
+ this.length = length;
}
private void readObjectNoData() throws ObjectStreamException {
http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/0a711ebc/parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java
----------------------------------------------------------------------
diff --git a/parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java b/parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java
index c8444dc..88aa4b2 100644
--- a/parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java
+++ b/parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java
@@ -18,8 +18,11 @@
*/
package org.apache.parquet.io.api;
+import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
import java.nio.ByteBuffer;
import java.util.Arrays;
@@ -29,6 +32,7 @@ import org.junit.Test;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
public class TestBinary {
@@ -227,6 +231,22 @@ public class TestBinary {
assertArrayEquals(testString.getBytes(UTF8), copy.copy().getBytes());
}
+ private void testSerializable(BinaryFactory bf, boolean reused) throws Exception {
+ BinaryAndOriginal bao = bf.get("polygon".getBytes(UTF8), reused);
+
+ ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ ObjectOutputStream out = new ObjectOutputStream(baos);
+ out.writeObject(bao.binary);
+ out.close();
+ baos.close();
+
+ ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(
+ baos.toByteArray()));
+ Object object = in.readObject();
+ assertTrue(object instanceof Binary);
+ assertEquals(bao.binary, object);
+ }
+
private void testBinary(BinaryFactory bf, boolean reused) throws Exception {
testSlice(bf, reused);
@@ -236,5 +256,6 @@ public class TestBinary {
testConstantCopy(bf);
}
+ testSerializable(bf, reused);
}
}