[GitHub] [druid] rohangarg commented on a diff in pull request #14089: Log merge and push timings for PartialGenericSegmentMergeTask

["rohangarg (via GitHub)" <gi...@apache.org>]

rohangarg commented on code in PR #14089:
URL: https://github.com/apache/druid/pull/14089#discussion_r1168340191


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -294,7 +300,20 @@ private Set<DataSegment> mergeAndPushSegments(
             exception -> !(exception instanceof NullPointerException) && exception instanceof Exception,
             5
         );
+        long pushFinishTime = System.nanoTime();
         pushedSegments.add(segment);
+        LOG.info(
+            "Segment[%s] of %,d bytes "
+            + "built from %d partial segment(s) in %,dms; "
+            + "pushed to deep storage in %,dms. "
+            + "Load spec is: %s",
+            segment.getId(),
+            segment.getSize(),
+            segmentFilesToMerge.size(),
+            (mergeFinishTime - startTime) / 1000000,
+            (pushFinishTime - mergeFinishTime) / 1000000,
+            jsonMapper.writeValueAsString(segment.getLoadSpec())

Review Comment:
   The load is logged at all other places, so this keeps the parity about the deep storage segment info.
   The interval is logged as a part of `SegmentId` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org