You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by GitBox <gi...@apache.org> on 2021/10/03 12:03:47 UTC
[GitHub] [openoffice] DiGro opened a new pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
DiGro opened a new pull request #139:
URL: https://github.com/apache/openoffice/pull/139
Just noticed the occurrence of the string "OpenOffice.org New Thesaurus" in the
dialog Writing Aids (Tools > Options > Language Settings > Writing Aids) in the
Developer Build 4.2.0
This should probably be changed to "New Thesaurus" only.
OpenGrok found the string just once, in:
/trunk/main/lingucomponent/source/thesaurus/libnth/nthesimp.cxx (revision
c4c42a0)
Line:
576 {
577 MutexGuard aGuard( GetLinguMutex() );
578 return A2OU( "OpenOffice.org New Thesaurus" );
579 }
Since I'm no developer at all I just deleted "OpenOffice.org".
Hope someone will check if I did it as supposed to.
Should probably also need to be changed in branches AOO41 and AOO42 too
Earlier reported in BugZilla Issue ID: 128483 https://bz.apache.org/ooo/show_bug.cgi?id=12
84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] dave2wave commented on pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
Posted by GitBox <gi...@apache.org>.
dave2wave commented on pull request #139:
URL: https://github.com/apache/openoffice/pull/139#issuecomment-938741468
This should be merged to AOO42X and AOO411X as well as trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
Posted by GitBox <gi...@apache.org>.
ardovm commented on pull request #139:
URL: https://github.com/apache/openoffice/pull/139#issuecomment-934728666
Looks good to me, because the string is not translated.
We could argue that translating this and other strings returned by `getServiceDisplayName(const Locale&)` methods would be a good idea: the `Locale` parameter is there for a reason... but IMHO it is not the purpose of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] ardovm merged pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
Posted by GitBox <gi...@apache.org>.
ardovm merged pull request #139:
URL: https://github.com/apache/openoffice/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] Pilot-Pirx commented on pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
Posted by GitBox <gi...@apache.org>.
Pilot-Pirx commented on pull request #139:
URL: https://github.com/apache/openoffice/pull/139#issuecomment-939273857
+1 for merging in all branches.
I am not sure if we should keep the "OpenOffice" for historical reasons but I am OK with "New Thesaurus"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] ardovm merged pull request #139: Occurence "OpenOffice.org" in dialog Writing Aids for new thesaurus
Posted by GitBox <gi...@apache.org>.
ardovm merged pull request #139:
URL: https://github.com/apache/openoffice/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org