You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "faga295 (via GitHub)" <gi...@apache.org> on 2026/10/20 11:10:59 UTC
[PR] feat(desktop): show automatic context compaction status during streaming [maka]
faga295 opened a new pull request, #6195:
URL: https://github.com/apache/maka/pull/6195
## Summary
Automatic context compaction can pause streaming without explaining why. Show its progress in the turn timeline, aligned with manual compaction, and settle each attempt as completed, failed, or interrupted so no stale progress indicator remains. Track attempts by compaction ID to handle repeated compactions without duplicate rows, and preserve their state across transcript replay and session continuity.
Fixes #5970
## Verification
- Full workspace test build (`npm run build:test`) and type checks (`npm run typecheck`) passed.
- `npm run lint` and `npm run format:check` passed.
- 16 targeted test files covering compaction/recovery, runtime context history, event mapping, Host protocol/continuity/transcripts, UI buffering/projection/materialization, CLI transcripts, and desktop trace refresh: **742 passed, 3 skipped, 0 failed**.
- UI regression coverage includes repeated attempts, failure/cancellation cleanup, and the handoff from live output to persisted history. Test command output:
```text
tests 745
pass 742
fail 0
cancelled 0
skipped 3
```
- Staged Biome, ASF license header, protocol epoch, and diff checks passed. The staged Biome check was rerun successfully with Node 24 after its Node 25 invocation stalled.
- No full workspace test suite, interactive Electron validation, or before/after screenshots were produced in this validation run.
## Protocol compatibility
Bump the Runtime Host compatibility epoch from 225 to 226: strict older peers cannot decode the new compaction lifecycle events or the additional fields on applied events.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex assisted with implementation, tests, conflict resolution, validation, and this PR description. Preserve the existing `Generated-by: Codex` trailer in the final squash commit.
## Checklist
- [ ] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Regression tests were run successfully; they were not rerun against an implementation with the feature removed.
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): show automatic context compaction status during streaming [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #6195:
URL: https://github.com/apache/maka/pull/6195#issuecomment-6309286628
> **Automated review notice:** This comment was posted by an automated review agent. It is not an independent human review and does not replace one.
Heads-up on the Runtime Host compatibility epoch: #6176 has merged, so `main` is now at **226** (`RUNTIME_HOST_COMPATIBILITY_EPOCH = 226` on `6104132`). This PR changes the Host protocol and currently declares 226, so it needs the next unused value (227 at the time of writing; #6195, #6206, #6091 and #6163 are all in the same position, and whichever merges first takes 227). Please rebase, bump the epoch and add the history comment in `packages/runtime-host/src/protocol/index.ts`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): show automatic context compaction status during streaming [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6195:
URL: https://github.com/apache/maka/pull/6195#discussion_r4346144600
##########
packages/runtime-host/src/protocol/index.ts:
##########
@@ -108,7 +108,10 @@ export const RUNTIME_HOST_PROTOCOL_VERSION = 0 as const;
// Increment when the same protocol version no longer guarantees safe Client-Host
// interoperability. Mismatches are rejected before domain commands are admitted.
// Re-check against main before merging; sibling PRs may use the same next epoch.
-export const RUNTIME_HOST_COMPATIBILITY_EPOCH = 226 as const;
+export const RUNTIME_HOST_COMPATIBILITY_EPOCH = 227 as const;
Review Comment:
P2 — advance the epoch after integrating current main. Main already uses 227 for Goal event waits, while this PR adds new context-compaction event variants and required fields. Keeping 227 would advertise protocol compatibility across different strict decoders. The current merge-result guard fails even after resolving the comment conflict; an epoch-only bump makes the guard pass. Pick an unused value above the current base and rerun CI, accounting for other pending epoch bumps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org