You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tian-pengfei (via GitHub)" <gi...@apache.org> on 2023/10/12 14:16:29 UTC
[PR] Fixs ineffective metadata registration [shenyu]
tian-pengfei opened a new pull request, #5221:
URL: https://github.com/apache/shenyu/pull/5221
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
When test http registration metadata in the new design ，it didnt work.
I found it was due to the missing 'registerMetaData' attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixs ineffective metadata registration [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5221:
URL: https://github.com/apache/shenyu/pull/5221#issuecomment-1759743985
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5221](https://app.codecov.io/gh/apache/shenyu/pull/5221?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8977d1f) into [master](https://app.codecov.io/gh/apache/shenyu/commit/f28a8e263fba8fd8dd50750ebfef1c4f3886fb4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f28a8e2) will **decrease** coverage by `0.68%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #5221 +/- ##
============================================
- Coverage 61.79% 61.12% -0.68%
+ Complexity 8579 8509 -70
============================================
Files 1248 1248
Lines 37753 37762 +9
Branches 3572 3570 -2
============================================
- Hits 23331 23081 -250
- Misses 12385 12690 +305
+ Partials 2037 1991 -46
```
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/register/registrar/MateDataApiRegistrarImpl.java](https://app.codecov.io/gh/apache/shenyu/pull/5221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9yZWdpc3RyYXIvTWF0ZURhdGFBcGlSZWdpc3RyYXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5221/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixs ineffective metadata registration [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #5221:
URL: https://github.com/apache/shenyu/pull/5221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org