[GitHub] [pinot] 61yao commented on a diff in pull request #9907: [multistage] [feature] Support Right join and Full join and inEqui mix.

[GitBox <gi...@apache.org>]

61yao commented on code in PR #9907:
URL: https://github.com/apache/pinot/pull/9907#discussion_r1048180412


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -146,10 +146,18 @@ public DataBlock.Type getType() {
    *
    * @return whether this block is the end of stream.
    */
+  // TODO: Update the name to isTerminateBlock.
   public boolean isEndOfStreamBlock() {
     return isType(MetadataBlock.MetadataBlockType.ERROR) || isType(MetadataBlock.MetadataBlockType.EOS);
   }
 
+  /**
+   * @return true when the block is a real end of stream block instead of error block.
+   */
+  public boolean isEOSBlock() {
+    return isType(MetadataBlock.MetadataBlockType.EOS);
+  }

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org