You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/05 06:00:47 UTC
Re: Review Request 63390: Create/destroy volume test for storage local
resource provider.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 6 a.m.)
Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Working test!
Repository: mesos
Description (updated)
-------
The unit test uses a mock framework to issue `CREATE_VOLUME` and
`DESTROY_VOLUME` operations to a storage local resource provider, which
uses the test CSI plugin, to create and destroy a CSI volume.
Diffs (updated)
-----
src/Makefile.am d5ca797c5a57a2763374d391a7e9358fe29f5e06
src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
src/tests/resource_provider/storage_local_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63390/diff/3/
Changes: https://reviews.apache.org/r/63390/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 63390: Create/destroy volume test for storage local
resource provider.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/#review193064
-----------------------------------------------------------
src/tests/resource_provider/storage_local_tests.cpp
Lines 1 (patched)
<https://reviews.apache.org/r/63390/#comment271559>
I'd not introduce the `resource_provider/` directory yet. We'll do that once there are more tests there.
src/tests/resource_provider/storage_local_tests.cpp
Lines 60-61 (patched)
<https://reviews.apache.org/r/63390/#comment271560>
I'd suggest we use the libtool wrapper so that you don't have to do the LD_LIBRARY_PATH trick below because libtool wrapper script does it for you
src/tests/resource_provider/storage_local_tests.cpp
Lines 65-103 (patched)
<https://reviews.apache.org/r/63390/#comment271561>
You can use string literal and strings::format to make it read nicer
src/tests/resource_provider/storage_local_tests.cpp
Lines 158-161 (patched)
<https://reviews.apache.org/r/63390/#comment271570>
I'd try to use unversioned API if possible so that we don't have to adjust the tests when we switch to v3 (deprecating v1)
- Jie Yu
On Dec. 6, 2017, 8:06 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63390/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 8:06 p.m.)
>
>
> Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The unit test uses a mock framework to issue `CREATE_VOLUME` and
> `DESTROY_VOLUME` operations to a storage local resource provider, which
> uses the test CSI plugin, to create and destroy a CSI volume.
>
>
> Diffs
> -----
>
> src/Makefile.am d5ca797c5a57a2763374d391a7e9358fe29f5e06
> src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
> src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
> src/tests/resource_provider/storage_local_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63390/diff/4/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 63390: Unit tests for storage local resource
provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 8:48 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
`DESTROY` before `DESTROY_VOLUME` and bypass `DESTROY` validation for provider resources.
Repository: mesos
Description
-------
This patche adds two unit tests. The first one will register a framework
to issue a `CREATE_VOLUME` then a `DESTROY_VOLUME` call to destroy
an unpublised volume. The second one will register a framework to issue
`CREATE_VOLUME`, `CREATE`, `LAUNCH`, `DESTROY_VOLUME` in sequence to
create a volume and launch a task to use a persistent volume on the CSI
volume, then destroy this published volume.
Diffs (updated)
-----
src/Makefile.am be105f485124579f70888bda69d3c37fd5a18770
src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
src/master/validation.cpp bf7ae65cad79c14f11e1858a16bd6d1b2f7745e7
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
src/tests/storage_local_resource_provider_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63390/diff/8/
Changes: https://reviews.apache.org/r/63390/diff/7-8/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 63390: Unit tests for storage local resource
provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 7:05 a.m.)
Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Addressed Jie's comments and added another test.
Summary (updated)
-----------------
Unit tests for storage local resource provider.
Repository: mesos
Description (updated)
-------
This patche adds two unit tests. The first one will register a framework
to issue a `CREATE_VOLUME` then a `DESTROY_VOLUME` call to destroy
an unpublised volume. The second one will register a framework to issue
`CREATE_VOLUME`, `CREATE`, `LAUNCH`, `DESTROY_VOLUME` in sequence to
create a volume and launch a task to use a persistent volume on the CSI
volume, then destroy this published volume.
Diffs (updated)
-----
src/Makefile.am be105f485124579f70888bda69d3c37fd5a18770
src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
src/tests/storage_local_resource_provider_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63390/diff/5/
Changes: https://reviews.apache.org/r/63390/diff/4-5/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 63390: Create/destroy volume test for storage local
resource provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 8:06 p.m.)
Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Added a GMock matcher.
Repository: mesos
Description
-------
The unit test uses a mock framework to issue `CREATE_VOLUME` and
`DESTROY_VOLUME` operations to a storage local resource provider, which
uses the test CSI plugin, to create and destroy a CSI volume.
Diffs (updated)
-----
src/Makefile.am d5ca797c5a57a2763374d391a7e9358fe29f5e06
src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
src/tests/resource_provider/storage_local_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63390/diff/4/
Changes: https://reviews.apache.org/r/63390/diff/3-4/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao