You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Kristian Koehler (JIRA)" <de...@geronimo.apache.org> on 2006/07/26 09:49:13 UTC

[jira] Created: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

GeronimoAsMavenServlet.java generates wrong default-repository element
----------------------------------------------------------------------

                 Key: GERONIMO-2228
                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: Plugins
    Affects Versions: 1.1, 1.1.1, 1.2
            Reporter: Kristian Koehler


The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:

--- 8< ---
...
<default-repository>
   HTTP/1.1://localhost:8081/console-standard/maven-repo/
</default-repository>

--- 8< ---

With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.

This should be:

--- 8< ---
...
<default-repository>
   http://localhost:8081/console-standard/maven-repo/
</default-repository>

--- 8< ---

The attached patch resolves this issue.

Kristian




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=all ]

Aaron Mulder updated GERONIMO-2228:
-----------------------------------

        Fix Version/s: 1.2
    Affects Version/s:     (was: 1.2)

Fixed in 1.1 branch.  Changes are applied to trunk, but there's still a problem (with copying modules with types other than "car") in trunk until GERONIMO-2258 is fixed in trunk too.

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.1
>            Reporter: Kristian Koehler
>         Assigned To: Aaron Mulder
>             Fix For: 1.2, 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Chris Cardona (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=all ]

Chris Cardona reassigned GERONIMO-2228:
---------------------------------------

    Assignee: Chris Cardona

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.2, 1.1
>            Reporter: Kristian Koehler
>         Assigned To: Chris Cardona
>             Fix For: 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=all ]

Aaron Mulder updated GERONIMO-2228:
-----------------------------------

    Assignee: Aaron Mulder  (was: Chris Cardona)

Also omits the namespace from the plugin list document

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.2, 1.1
>            Reporter: Kristian Koehler
>         Assigned To: Aaron Mulder
>             Fix For: 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=all ]

Aaron Mulder closed GERONIMO-2228.
----------------------------------

    Fix Version/s:     (was: 1.2)
       Resolution: Fixed

Closing as fixed in 1.1.1 -- separate issue created for trunk

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.1
>            Reporter: Kristian Koehler
>         Assigned To: Aaron Mulder
>             Fix For: 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Kristian Koehler (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=all ]

Kristian Koehler updated GERONIMO-2228:
---------------------------------------

    Attachment: diff.patch

the patch

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.2, 1.1, 1.1.1
>            Reporter: Kristian Koehler
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=comments#action_12424902 ] 
            
Aaron Mulder commented on GERONIMO-2228:
----------------------------------------

Also seems to expect Maven 1 repository IDs not Maven 2.  Looks like this was pretty crusty code!

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.2, 1.1
>            Reporter: Kristian Koehler
>         Assigned To: Aaron Mulder
>             Fix For: 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=comments#action_12424898 ] 
            
Aaron Mulder commented on GERONIMO-2228:
----------------------------------------

Also does not handle artifacts with a . in the groupId, like console.dbpool/something/1.0/rar

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.2, 1.1
>            Reporter: Kristian Koehler
>         Assigned To: Aaron Mulder
>             Fix For: 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-2228) GeronimoAsMavenServlet.java generates wrong default-repository element

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-2228?page=all ]

Aaron Mulder updated GERONIMO-2228:
-----------------------------------

        Fix Version/s: 1.1.1
    Affects Version/s:     (was: 1.1.1)

> GeronimoAsMavenServlet.java generates wrong default-repository element
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-2228
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2228
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Plugins
>    Affects Versions: 1.1, 1.2
>            Reporter: Kristian Koehler
>             Fix For: 1.1.1
>
>         Attachments: diff.patch
>
>
> The GeronimoAsMavenServlet generates a XML document which contains an element called 'default-repository' (see http://localhost:8080/console-standard/maven-repo/geronimo-plugins.xml). The value of this element looks like:
> --- 8< ---
> ...
> <default-repository>
>    HTTP/1.1://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> With this issue it isn't possible to import a plugin from a Geronimo Server running somewhere.
> This should be:
> --- 8< ---
> ...
> <default-repository>
>    http://localhost:8081/console-standard/maven-repo/
> </default-repository>
> --- 8< ---
> The attached patch resolves this issue.
> Kristian

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira