You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/17 07:38:06 UTC

[kudu-CR] [tools] add test coverage for flags categories in ksck 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15458


Change subject: [tools] add test coverage for flags categories in ksck
......................................................................

[tools] add test coverage for flags categories in ksck

This patch updates the ksck-test to cover the functionality introduced
in changelist a9afbce14454f9b03b9cc5a699a09f4f9935da58.

I also updated the output of ksck to unify the naming of tablet servers
between different parts of the ksck output; one other minor formatting
change in the description of the --flags_categories_to_check flag.

Change-Id: Ib24b1ee38ffda6b551b1b84fd356a4581e1fe256
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 156 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15458/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib24b1ee38ffda6b551b1b84fd356a4581e1fe256
Gerrit-Change-Number: 15458
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [tools] add test coverage for flags categories in ksck

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15458 )

Change subject: [tools] add test coverage for flags categories in ksck
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib24b1ee38ffda6b551b1b84fd356a4581e1fe256
Gerrit-Change-Number: 15458
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 17:05:51 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] add test coverage for flags categories in ksck

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15458 )

Change subject: [tools] add test coverage for flags categories in ksck
......................................................................

[tools] add test coverage for flags categories in ksck

This patch updates the ksck-test to cover the functionality introduced
in changelist a9afbce14454f9b03b9cc5a699a09f4f9935da58.

I also updated the output of ksck to unify the naming of tablet servers
between different parts of the ksck output; one other minor formatting
change in the description of the --flags_categories_to_check flag.

Change-Id: Ib24b1ee38ffda6b551b1b84fd356a4581e1fe256
Reviewed-on: http://gerrit.cloudera.org:8080/15458
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 156 insertions(+), 4 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib24b1ee38ffda6b551b1b84fd356a4581e1fe256
Gerrit-Change-Number: 15458
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)