[GitHub] [spark] cloud-fan commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue

[GitBox <gi...@apache.org>]

cloud-fan commented on issue #24902: [SPARK-28093][SQL] Fix TRIM/LTRIM/RTRIM function parameter order issue
URL: https://github.com/apache/spark/pull/24902#issuecomment-584511167
 
 
   I don't see the specification of the TRIM function parameters order in the SQL standard, and I assume it's vendor-specific. I agree that most SQL systems use the new order, but it doesn't mean the old order is wrong.
   
   More importantly, the SQL standard does define the TRIM syntax as `TRIM ( [ characters FROM ] string )`, and I think this is the thing we should follow. I'd suggest we revert this commit (how can users figure out the parameter order of a function is changed? TRIM is a common function and this can break many queries silently.). We can implement `TRIM ( [ characters FROM ] string )` in 3.1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org