You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2014/09/25 16:24:22 UTC

[2/4] git commit: reduce JmsMessageId to a single constructor

reduce JmsMessageId to a single constructor


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/11e9f52c
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/11e9f52c
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/11e9f52c

Branch: refs/heads/master
Commit: 11e9f52c42dec0fe371bc4b9ea239413049e33d5
Parents: 1af530a
Author: Robert Gemmell <ro...@apache.org>
Authored: Thu Sep 25 11:26:16 2014 +0100
Committer: Robert Gemmell <ro...@apache.org>
Committed: Thu Sep 25 15:23:42 2014 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/qpid/jms/JmsSession.java   |  2 +-
 .../java/org/apache/qpid/jms/meta/JmsMessageId.java     | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/11e9f52c/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
index a7ede86..92aa83a 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java
@@ -859,7 +859,7 @@ public class JmsSession implements Session, QueueSession, TopicSession, JmsMessa
     }
 
     private JmsMessageId getNextMessageId(JmsMessageProducer producer) {
-        return new JmsMessageId(producer.getProducerId(), producer.getNextMessageSequence());
+        return new JmsMessageId(producer.getProducerId().toString() + "-" + producer.getNextMessageSequence());
     }
 
     private <T extends JmsMessage> T init(T message) {

http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/11e9f52c/qpid-jms-client/src/main/java/org/apache/qpid/jms/meta/JmsMessageId.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/meta/JmsMessageId.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/meta/JmsMessageId.java
index 1698231..9a75242 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/meta/JmsMessageId.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/meta/JmsMessageId.java
@@ -24,18 +24,6 @@ public class JmsMessageId extends JmsAbstractResourceId implements Comparable<Jm
 
     protected String messageId;
 
-    public JmsMessageId(JmsProducerInfo producerInfo, long producerSequenceId) {
-        this(producerInfo.getProducerId(), producerSequenceId);
-    }
-
-    public JmsMessageId(JmsProducerId producerId, long producerSequenceId) {
-        this(producerId.toString(), producerSequenceId);
-    }
-
-    public JmsMessageId(String producerId, long producerSequenceId) {
-        this(producerId + "-" + producerSequenceId);
-    }
-
     public JmsMessageId(String messageId) {
         this.messageId = messageId;
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org