You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by "proost (via GitHub)" <gi...@apache.org> on 2023/04/29 14:44:51 UTC
[GitHub] [bahir-flink] proost opened a new pull request, #164: [BAHIR-285] feat: add srem
proost opened a new pull request, #164:
URL: https://github.com/apache/bahir-flink/pull/164
support srem command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on a diff in pull request #164: [BAHIR-285] feat: add srem
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on code in PR #164:
URL: https://github.com/apache/bahir-flink/pull/164#discussion_r1209842067
##########
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkITCase.java:
##########
@@ -77,14 +77,21 @@ public void testRedisListDataType() throws Exception {
@Test
public void testRedisSetDataType() throws Exception {
Review Comment:
could we have a separated test for remove..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #164: [BAHIR-285] feat: add srem
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on PR #164:
URL: https://github.com/apache/bahir-flink/pull/164#issuecomment-1567938443
Hi @proost,
thanks for your contribution.. do you have a apache jira account to set the issue to you and merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] proost commented on pull request #164: [BAHIR-285] feat: add srem
Posted by "proost (via GitHub)" <gi...@apache.org>.
proost commented on PR #164:
URL: https://github.com/apache/bahir-flink/pull/164#issuecomment-1537365264
Hi @eskabetxe , could you take a look and trigger the checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe merged pull request #164: [BAHIR-285] Redis: add srem command
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe merged PR #164:
URL: https://github.com/apache/bahir-flink/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on pull request #164: [BAHIR-285] Redis: add srem command
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on PR #164:
URL: https://github.com/apache/bahir-flink/pull/164#issuecomment-1568705707
@proost thanks for contribution
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] proost commented on pull request #164: [BAHIR-285] Redis: add srem command
Posted by "proost (via GitHub)" <gi...@apache.org>.
proost commented on PR #164:
URL: https://github.com/apache/bahir-flink/pull/164#issuecomment-1568683730
@eskabetxe
Yes, I have a jira account. My username is "proost" and full name is "Hyeonho Kim"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir-flink] eskabetxe commented on a diff in pull request #164: [BAHIR-285] feat: add srem
Posted by "eskabetxe (via GitHub)" <gi...@apache.org>.
eskabetxe commented on code in PR #164:
URL: https://github.com/apache/bahir-flink/pull/164#discussion_r1209842067
##########
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkITCase.java:
##########
@@ -77,14 +77,21 @@ public void testRedisListDataType() throws Exception {
@Test
public void testRedisSetDataType() throws Exception {
Review Comment:
could we have a separated test for remove..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org