You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by "duncangrant (via GitHub)" <gi...@apache.org> on 2023/03/10 16:37:13 UTC
[GitHub] [brooklyn-client] duncangrant opened a new pull request, #97: Issue with sslcheck flag
duncangrant opened a new pull request, #97:
URL: https://github.com/apache/brooklyn-client/pull/97
There was a global flag and a command flag and both are not supported so now there's only a command flag
Also updated to latest go, which had some knock-on effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-client] duncangrant merged pull request #97: Issue with sslcheck flag
Posted by "duncangrant (via GitHub)" <gi...@apache.org>.
duncangrant merged PR #97:
URL: https://github.com/apache/brooklyn-client/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-client] duncangrant commented on pull request #97: Issue with sslcheck flag
Posted by "duncangrant (via GitHub)" <gi...@apache.org>.
duncangrant commented on PR #97:
URL: https://github.com/apache/brooklyn-client/pull/97#issuecomment-1464080227
I've built this locally using go build and it fixes the flag issue however I can't get the docker build to work locally so I don't know how this will work in CI. It passes though so I guess it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-client] duncangrant commented on a diff in pull request #97: Issue with sslcheck flag
Posted by "duncangrant (via GitHub)" <gi...@apache.org>.
duncangrant commented on code in PR #97:
URL: https://github.com/apache/brooklyn-client/pull/97#discussion_r1132601887
##########
cli/app/app.go:
##########
@@ -52,10 +52,10 @@ func NewApp(baseName string, cmdRunner command_runner.Runner, metadatas ...comma
app.Version = appConfig.Version
app.Flags = []cli.Flag{
- &cli.BoolFlag{
- Name: "skipSslChecks",
- Usage: "Skip verification of server's certificate chain and hostname (for use with self-signed certs)",
- },
+ //&cli.BoolFlag{
+ // Name: "skipSslChecks",
+ // Usage: "Skip verification of server's certificate chain and hostname (for use with self-signed certs)",
+ //},
Review Comment:
I'll remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org