You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/23 10:33:00 UTC

[GitHub] [flink] wanglijie95 opened a new pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

wanglijie95 opened a new pull request #12754:
URL: https://github.com/apache/flink/pull/12754


   …essingTimeTrigger
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   Fix NPE on SessionWindows with `ContinuousProcessingTimeTrigger`, as described in FLINK-5717.
   
   ## Brief change log
   Fix the NPE error when SessionWindows with `ContinuousProcessingTimeTrigger` is used.
   
   ## Verifying this change
   
   Add `testSessionWindowsWithContinuousProcessingTimeTrigger` in `WindowOperatorTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648976755


   > Thanks for the fix! I think, however, that `WindowOperatorTest` is not the right place to put the test, it should be added in `ContinuousProcessingTimeTriggerTest`. I know that the fix for `ContinuousEventTimeTrigger` also made this mistake but we should now fix it. For this you would first need to add the `Test`, you can do this based on `ContinuousEventTimeTriggerTest` and then add a new test for this fix there. What do you think?
   
   Thanks for review!  You are right, `ContinuousProcessingTimeTriggerTest` is more suitable. I will change it later.
   As for the mistake maded by the fix for `ContinuousEventTimeTrigger`, I think it should be fixed in a new PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12754:
URL: https://github.com/apache/flink/pull/12754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648062078


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7d083b1c3bbbf2c621892c7396c854340bd3ee1e (Fri Feb 19 07:26:47 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648071778


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7d083b1c3bbbf2c621892c7396c854340bd3ee1e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3954",
       "triggerID" : "7d083b1c3bbbf2c621892c7396c854340bd3ee1e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7d083b1c3bbbf2c621892c7396c854340bd3ee1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3954) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-650986546


   Yes, I think you're right on both questions. The `maxTimestamp` trigger was introduced in https://issues.apache.org/jira/browse/FLINK-5149, but not for the processing-time trigger.
   
   In general, I think the continuous triggers are a bit weird and not many people use them, that's why they managed to keep these bugs for so long. 😅


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-698839205


   I'm closing this as "Abandoned", since there is no more activity. Please re-open if you want to continue working on this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #12754:
URL: https://github.com/apache/flink/pull/12754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648709304


   Thanks for the fix! I think, however, that `WindowOperatorTest` is not the right place to put the test, it should be added in `ContinuousProcessingTimeTriggerTest`. I know that the fix for `ContinuousEventTimeTrigger` also made this mistake but we should now fix it. For this you would first need to add the `Test`, you can do this based on `ContinuousEventTimeTriggerTest` and then add a new test for this fix there. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-698839205


   I'm closing this as "Abandoned", since there is no more activity. Please re-open if you want to continue working on this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648071778


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7d083b1c3bbbf2c621892c7396c854340bd3ee1e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7d083b1c3bbbf2c621892c7396c854340bd3ee1e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7d083b1c3bbbf2c621892c7396c854340bd3ee1e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648071778


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7d083b1c3bbbf2c621892c7396c854340bd3ee1e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3954",
       "triggerID" : "7d083b1c3bbbf2c621892c7396c854340bd3ee1e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7d083b1c3bbbf2c621892c7396c854340bd3ee1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3954) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-651046093


   OK, I will  fix them by the way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 edited a comment on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
wanglijie95 edited a comment on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-650017734


   Hi @aljoscha , when I checked the implementation of `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger`, I was confused in two methods :  `OnElement` and `clear`.
   
   First of all, I think that `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger` should also fire at the end of window. I saw that `ContinuousEventTimeTrigge` has registered a timer with `window.maxTimestamp()` in `OnElement` : https://github.com/apache/flink/blob/6227fffbe67c9ce4c5591ed1e940f6c34ee137bb/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java#L59
   But I didn't find that in `ContinuousProcessingTimeTrigger.`.
   
   Secondly, I think that `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger` should delete the timer with `window.maxTimestamp()` in `clear`, but they didn't. 
   
   Are the above bugs? Or some other considerations, I am a little confused.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-649407553


   Feel free to fix `ContinuousEventTimeTrigger` and ping me in the PR. 👌


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wanglijie95 commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-650017734


   Hi @aljoscha , when I checked the implementation of `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger`, I was confused in two methods :  `OnElement` and `clear`.
   
   First of all, I think that `ContinuousEventTimeTrigger` and `ContinuousProcessingTimeTrigger` should also fire at the end of window. I saw that `ContinuousEventTimeTrigge` has registered a timer with `window.maxTimestamp()` in `OnElement` : https://github.com/apache/flink/blob/6227fffbe67c9ce4c5591ed1e940f6c34ee137bb/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java#L59
   But I didn't find that in `ContinuousProcessingTimeTrigger.`.
   
   Secondly, I think that `ContinuousEventTimeTrigger` should delete the timer with `window.maxTimestamp()` in `clear`, but it didn't. 
   
   Are the above bugs? Or some other considerations, I am a little confused.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12754:
URL: https://github.com/apache/flink/pull/12754#issuecomment-648062078


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7d083b1c3bbbf2c621892c7396c854340bd3ee1e (Tue Jun 23 10:42:29 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-5717).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org