[GitHub] [flink] zhoulii commented on a diff in pull request #20082: [FLINK-28134][runtime] Introduce SpeculativeExecutionVertex

[GitBox <gi...@apache.org>]

zhoulii commented on code in PR #20082:
URL: https://github.com/apache/flink/pull/20082#discussion_r907951115


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java:
##########
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.jobmaster.LogicalSlot;
+import org.apache.flink.runtime.taskmanager.TaskManagerLocation;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.runtime.execution.ExecutionState.FAILED;
+import static org.apache.flink.runtime.execution.ExecutionState.FINISHED;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The ExecutionVertex which supports speculative execution. */
+public class SpeculativeExecutionVertex extends ExecutionVertex {
+
+    private Map<ExecutionAttemptID, Execution> currentExecutions;
+
+    public SpeculativeExecutionVertex(
+            ExecutionJobVertex jobVertex,
+            int subTaskIndex,
+            IntermediateResult[] producedDataSets,
+            Time timeout,
+            long createTimestamp,
+            int maxPriorExecutionHistoryLength,
+            int initialAttemptCount) {
+        super(
+                jobVertex,
+                subTaskIndex,
+                producedDataSets,
+                timeout,
+                createTimestamp,
+                maxPriorExecutionHistoryLength,
+                initialAttemptCount);
+
+        this.currentExecutions = new LinkedHashMap<>();
+        this.currentExecutions.put(currentExecution.getAttemptId(), currentExecution);
+    }
+
+    public boolean containsSources() {
+        return getJobVertex().getJobVertex().containsSources();
+    }
+
+    public boolean containsSinks() {
+        return getJobVertex().getJobVertex().containsSinks();
+    }
+
+    public Execution createNewSpeculativeExecution(final long timestamp) {
+        final Execution newExecution = createNewExecution(timestamp);
+        getExecutionGraphAccessor().registerExecution(newExecution);
+        currentExecutions.put(newExecution.getAttemptId(), newExecution);
+        return newExecution;
+    }
+
+    @Override
+    public Collection<Execution> getCurrentExecutions() {
+        return Collections.unmodifiableCollection(currentExecutions.values());
+    }
+
+    @Override
+    public Execution getPartitionProducer() {
+        final Execution finishedExecution = getCurrentExecutionAttempt();
+        checkState(
+                finishedExecution.getState() == FINISHED,
+                "It's not allowed to get the partition producer of an un-finished speculative execution vertex");
+        return finishedExecution;
+    }
+
+    @Override
+    public CompletableFuture<?> cancel() {
+        final List<CompletableFuture<?>> cancelResultFutures = new ArrayList<>();
+        for (Execution execution : currentExecutions.values()) {
+            execution.cancel();
+            cancelResultFutures.add(execution.getReleaseFuture());
+        }
+        return FutureUtils.combineAll(cancelResultFutures);
+    }
+
+    @Override
+    public CompletableFuture<?> suspend() {
+        return FutureUtils.combineAll(
+                currentExecutions.values().stream()
+                        .map(Execution::suspend)
+                        .collect(Collectors.toList()));
+    }
+
+    @Override
+    public void fail(Throwable t) {
+        currentExecutions.values().forEach(e -> e.fail(t));
+    }
+
+    @Override
+    public void markFailed(Throwable t) {
+        currentExecutions.values().forEach(e -> e.markFailed(t));
+    }
+
+    @Override
+    CompletableFuture<?> getTerminationFuture() {
+        final List<CompletableFuture<?>> terminationFutures =
+                currentExecutions.values().stream()
+                        .map(e -> e.getTerminalStateFuture())
+                        .collect(Collectors.toList());
+        return FutureUtils.waitForAll(terminationFutures);
+    }
+
+    @Override
+    public void resetForNewExecution() {
+        super.resetForNewExecution();
+
+        currentExecutions.clear();
+        currentExecutions.put(currentExecution.getAttemptId(), currentExecution);
+    }
+
+    @Override
+    void resetExecutionsInternal() {
+        for (Execution execution : currentExecutions.values()) {
+            resetExecution(execution);
+        }
+    }
+
+    /**
+     * Remove execution from currentExecutions if it is failed. It is needed to make room for
+     * possible future speculative executions.
+     *
+     * @param executionAttemptId attemptID of the execution to be removed
+     */
+    public void archiveFailedExecution(ExecutionAttemptID executionAttemptId) {
+        if (this.currentExecutions.size() <= 1) {
+            // Leave the last execution because currentExecutions should never be empty. This should
+            // happen only if all current executions have FAILED. A vertex reset will happen soon
+            // and will archive the remaining execution.
+            return;
+        }
+
+        final Execution removedExecution = this.currentExecutions.remove(executionAttemptId);
+        checkNotNull(
+                removedExecution,
+                String.format(
+                        "Cannot remove execution %s which does not exist.", executionAttemptId));
+        checkState(
+                removedExecution.getState() == FAILED,
+                "Cannot remove execution %s which is not FAILED.",
+                executionAttemptId);
+
+        executionHistory.add(removedExecution.archive());
+        if (removedExecution == this.currentExecution) {
+            this.currentExecution = this.currentExecutions.values().iterator().next();
+        }
+    }
+
+    @Override
+    public Execution getCurrentExecutionAttempt() {
+        // returns the execution which is most likely to reach FINISHED state
+        Execution currentExecution = this.currentExecution;
+        for (Execution execution : currentExecutions.values()) {
+            if (getStatePriority(execution.getState())
+                    < getStatePriority(currentExecution.getState())) {
+                currentExecution = execution;
+            }
+        }
+        return currentExecution;
+    }
+
+    private int getStatePriority(ExecutionState state) {
+        // the more likely to reach FINISHED state, the higher priority, the smaller value
+        switch (state) {
+                // CREATED/SCHEDULED/INITIALIZING/RUNNING/FINISHED are healthy states with an
+                // increasing priority
+            case FINISHED:
+                return 0;
+            case RUNNING:
+                return 1;
+            case INITIALIZING:
+                return 2;
+            case DEPLOYING:
+                return 3;
+            case SCHEDULED:
+                return 4;
+            case CREATED:
+                return 5;
+                // if the vertex is not in an healthy state, shows its CANCELING state unless it is

Review Comment:
   ```suggestion
                   // if the vertex is not in a healthy state, shows its CANCELING state unless it is
   ```



##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java:
##########
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.execution.ExecutionState;
+import org.apache.flink.runtime.jobmaster.LogicalSlot;
+import org.apache.flink.runtime.taskmanager.TaskManagerLocation;
+import org.apache.flink.util.concurrent.FutureUtils;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.runtime.execution.ExecutionState.FAILED;
+import static org.apache.flink.runtime.execution.ExecutionState.FINISHED;
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** The ExecutionVertex which supports speculative execution. */
+public class SpeculativeExecutionVertex extends ExecutionVertex {
+
+    private Map<ExecutionAttemptID, Execution> currentExecutions;

Review Comment:
   can be final



##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedSpeculativeExecutionVertex.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+/**
+ * {@code ArchivedSpeculativeExecutionVertex} is a readonly representation of {@link
+ * SpeculativeExecutionVertex}.
+ */
+public class ArchivedSpeculativeExecutionVertex extends ArchivedExecutionVertex {
+
+    private static final long serialVersionUID = 1L;
+
+    public ArchivedSpeculativeExecutionVertex(SpeculativeExecutionVertex vertex) {
+        super(
+                vertex.getParallelSubtaskIndex(),
+                vertex.getTaskNameWithSubtaskIndex(),
+                vertex.getCurrentExecutionAttempt().archive(),
+                getCopyOfExecutionHistory(vertex));
+    }
+
+    private static ExecutionHistory getCopyOfExecutionHistory(SpeculativeExecutionVertex vertex) {
+        final ExecutionHistory executionHistory =

Review Comment:
   Does this `executionHistory`  already contain the only admitted current execution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org