You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/04/24 13:25:22 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #6108: Review use of DataFusion::Internal and ensure they are returned for bugs in DataFusion

alamb opened a new issue, #6108:
URL: https://github.com/apache/arrow-datafusion/issues/6108

   ### Is your feature request related to a problem or challenge?
   
   https://github.com/search?q=repo%3Aapache%2Farrow-datafusion+DataFusionError%3A%3AInternal&type=code
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] wolffcm commented on issue #6108: Review use of DataFusion::Internal and ensure they are returned for bugs in DataFusion

Posted by "wolffcm (via GitHub)" <gi...@apache.org>.
wolffcm commented on issue #6108:
URL: https://github.com/apache/arrow-datafusion/issues/6108#issuecomment-1520608282

   I think one such place where `Internal` is returned when it should not be is here:
   https://github.com/apache/arrow-datafusion/blob/729586258fe6371e394b8b2caa4e1b55eccbf6c5/datafusion/optimizer/src/optimizer.rs#L307-L311
   
   Logical optimizer rules should be able to fail in a way that advises the user on how to correct their query, rather than having the optimizer assume that any error is internal. This is relevant to https://github.com/influxdata/influxdb_iox/issues/7330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org