You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/15 08:28:17 UTC
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14443
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and did minor fixes on formatting.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/1
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14443
to look at the new patch set (#7).
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and other security-related tips. Fixed formatting.
Updated the paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 114 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/7
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14443
to look at the new patch set (#6).
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and other security-related tips. Fixed formatting.
Updated the paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 101 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/6
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/6/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/14443/6/RELEASING.adoc@163
PS6, Line 163: gpg --list-secret-keys --keyid-format=short
What about the master branch? That's probably where most users go for examples.
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Nov 2019 22:00:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 6: Verified+1
Unrelated test failures (doc-only change):
* DeleteTabletITest.TestLeaderElectionDuringDeleteTablet
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 22:11:57 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14443
to look at the new patch set (#3).
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and did minor fixes on formatting. Updated the
paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 64 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/3
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/1/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/14443/1/RELEASING.adoc@126
PS1, Line 126: ./gradlew clean install -Psigning.gnupg.keyName=<8-character-pgp-key-id>
I think forceSigning is still needed here or else signing won't happen given the version still contains -SNAPSHOT.
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 13:23:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14443
to look at the new patch set (#4).
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and did minor fixes on formatting. Updated the
paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 77 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/4
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14443
to look at the new patch set (#5).
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and did minor fixes on formatting. Updated the
paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 82 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/5
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/5/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/14443/5/RELEASING.adoc@150
PS5, Line 150: ./gradlew clean install -Psigning.gnupg.keyName=<8-character-pgp-key-id>
> I think we should keep `-PforceSigning` to ensure things are signed. I will
Done
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 20:35:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 1: Verified+1
Unrelated test failure in:
* BuiltinNtpWithMiniChronydTest.SyncAndUnsyncReferenceServers
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:28:54 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/6/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/14443/6/RELEASING.adoc@163
PS6, Line 163: . In the newly created branch `branch-1.x.y` of the project git repo, update
> What about the master branch? That's probably where most users go for examp
That's addressed in the very last item in this file.
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Nov 2019 22:33:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/2/RELEASING.adoc
File RELEASING.adoc:
PS2:
Pre-rendered version of this .adoc file is available at https://gist.github.com/alexeyserbin/cab25485634f0da6f05011173014a945
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 23:59:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and other security-related tips. Fixed formatting.
Updated the paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Reviewed-on: http://gerrit.cloudera.org:8080/14443
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M RELEASING.adoc
1 file changed, 114 insertions(+), 62 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14443
to look at the new patch set (#2).
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
[docs] gradle-related update on RELEASING.adoc
This patch updates gradle-related instructions for building the release
candidate. Also, added a section about forwarding gpg-agent to a remote
system over SSH and did minor fixes on formatting. Updated the
paragraph about staging maven repository with RC artifacts.
Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
---
M RELEASING.adoc
1 file changed, 56 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14443/2
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/1/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/14443/1/RELEASING.adoc@126
PS1, Line 126: ./gradlew clean install -Psigning.gnupg.keyName=<8-character-pgp-key-id>
> I think forceSigning is still needed here or else signing won't happen give
It works for me without the 'forceSigning' flag, at least with Gradle 5.4.1
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:19:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] gradle-related update on RELEASING.adoc
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14443 )
Change subject: [docs] gradle-related update on RELEASING.adoc
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14443/5/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/14443/5/RELEASING.adoc@150
PS5, Line 150: ./gradlew clean install -Psigning.gnupg.keyName=<8-character-pgp-key-id>
I think we should keep `-PforceSigning` to ensure things are signed. I will work on updating/fixing the the gradle release code.
--
To view, visit http://gerrit.cloudera.org:8080/14443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I861d30615e53d5d6c76bbd01da13e3f2a540e882
Gerrit-Change-Number: 14443
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 12 Nov 2019 13:41:59 +0000
Gerrit-HasComments: Yes