[GitHub] [incubator-nuttx] sebastianene07 commented on pull request #1009: Add support for preemptive scheduling in simulator build

[GitBox <gi...@apache.org>]

sebastianene07 commented on pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#issuecomment-626176498


   > @sebastianene07 I stop to review the last several patch because it's better to reorg your patch into a meaning set. For example, I found serveral patch fix the problem in the previous one.
   > And basically, the better change is enhance up_oneshot.c which is much simple and get the tickless support free:
   > 1.Register alarm timer in up_oneshot.c
   > 2.Call back to NuttX in signal action
   > 3.Modify up_irq_save/up_irq_restore to disable/enable signal
   > I don't think it's nessary to use ucontext API.
   
   I used ucontext API because it can restore the signal mask after a call to ```swapcontext```. The setjmp/longjmp mechanism doesn't seem to work with signals. Do you think it's better to close this PR and re-open a different one with the suggested changes ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org