[GitHub] [superset] robdiciuccio commented on a change in pull request #13837: fix(native-filters): add global async query support to native filters

[GitBox <gi...@apache.org>]

robdiciuccio commented on a change in pull request #13837:
URL: https://github.com/apache/superset/pull/13837#discussion_r603555983



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
##########
@@ -76,12 +80,28 @@ const FilterValue: React.FC<FilterProps> = ({
         requestParams: { dashboardId: 0 },
       })
         .then(response => {
-          setState(response.result);
-          setError(false);
-          setLoading(false);
+          if (isFeatureEnabled(FeatureFlag.GLOBAL_ASYNC_QUERIES)) {
+            // deal with getChartDataRequest transforming the response data
+            const result = 'result' in response ? response.result[0] : response;

Review comment:
       Nit: maybe we should update `getChartDataRequest` to _not_ modify the response format?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org