[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #701: feat: deploy with docker

[GitBox <gi...@apache.org>]

gxthrj commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519668804



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       now use `docker-conf-example.yaml` instead of `docker-conf-example.json`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org