You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/14 17:53:52 UTC
[jira] [Commented] (SHINDIG-1773) Content proxy needs to support
proxy for OAuth protected resources
[ https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274693#comment-13274693 ]
jiraposter@reviews.apache.org commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/
-----------------------------------------------------------
Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian Lillie.
Summary
-------
Couple of changes are included in this patch.
1) On the client side, the getProxyUrl is updated to add auth parameter to specify the auth scheme used, also check for the AUTHORIZATION and OAUTH_SERVICE setting and add them in proxy url.
2) On the server side, proxy servlet will pass additional HttpServletRequest to ProxyHandler to build the HttpRequest object, in the ProxyHandler additional information as security token, auth type, oauth service and gadget will be used to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.
This addresses bug Shindig-1773.
https://issues.apache.org/jira/browse/Shindig-1773
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1338171
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1338232
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java 1338123
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java 1335359
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml 1335359
Diff: https://reviews.apache.org/r/5112/diff
Testing
-------
Thanks,
Xiao Feng
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are desired to be accessed via content proxy instead of makeRequest calls, for example, images in user's album. User should be able to specify OAuth parameter in getProxyUrl call and get a proxy url to access the protected resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira