[GitHub] [dolphinscheduler] lenboo commented on a change in pull request #6639: [DS-6638][MasterServer] fix task state no change when failover worker

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #6639:
URL: https://github.com/apache/dolphinscheduler/pull/6639#discussion_r739194569



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryClient.java
##########
@@ -343,7 +340,6 @@ private void failoverMaster(String masterHost) {
             }
             processService.processNeedFailoverProcessInstances(processInstance);
         }
-        failoverWorker(masterHost, true, false);

Review comment:
       i think we need it in this case:
   1. worker-1 down, then master-1 failover [the tasks that workflow is running on 'master-1']
   2. master-1 down. 
   3. master-2 failover 'master-1 down' event, and it also need failover [the tasks that workflow is running on 'master-1']




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org