You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by "nanonyme (via GitHub)" <gi...@apache.org> on 2024/04/12 21:54:51 UTC

Re: [PR] cargo: Add support for git dependencies [buildstream-plugins]

nanonyme commented on PR #62:
URL: https://github.com/apache/buildstream-plugins/pull/62#issuecomment-2052610970

   Just a thought but it would be nice if the tomlkit dependency was optional and became fatal only if there actually are git crates. The existing dependency tomllib is in Python standard library while this one implies user installing packages which is not automatic when this is consumed as junction like freedesktop-sdk and gnome-build-meta do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org