You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by nycholas <gi...@git.apache.org> on 2017/08/29 17:26:59 UTC

[GitHub] flink pull request #4617: [FLINK-7556] Fix fetch size configurable in JDBCIn...

GitHub user nycholas opened a pull request:

    https://github.com/apache/flink/pull/4617

    [FLINK-7556] Fix fetch size configurable in JDBCInputFormat for MySQL Driver

    According to the MySQL documentation[1], it follows:
    
    * ResultSet
    
    > By default, ResultSets are completely retrieved and stored in memory. In most cases this is the most efficient way to operate and, due to the design of the MySQL network protocol, is easier to implement. If you are working with ResultSets that have a large number of rows or large values and cannot allocate heap space in your JVM for the memory required, you can tell the driver to stream the results back one row at a time.
    
    > To enable this functionality, create a Statement instance in the following manner:
    
    ```
    stmt = conn.createStatement(java.sql.ResultSet.TYPE_FORWARD_ONLY,
                  java.sql.ResultSet.CONCUR_READ_ONLY);
    stmt.setFetchSize(Integer.MIN_VALUE);
    
    ```
    
    > The combination of a forward-only, read-only result set, with a fetch size of Integer.MIN_VALUE serves as a signal to the driver to stream result sets row-by-row. After this, any result sets created with the statement will be retrieved row-by-row.
    
    
    Allow the Integer.MIN_VALUE to be accepted as a parameter for setFetchSize.
    
    [1] - https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-implementation-notes.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cenobites/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4617.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4617
    
----
commit 82535fd09cf52cb3e1c3da162dc807d7d889ac19
Author: Nycholas de Oliveira e Oliveira <ny...@gmail.com>
Date:   2017-08-29T17:21:03Z

    [FLINK-7556] Fix fetch size configurable in JDBCInputFormat for MySQL Driver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4617: [FLINK-7556] Fix fetch size configurable in JDBCInputForm...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4617
  
    Thanks for the PR @nycholas.
    
    +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4617: [FLINK-7556] Fix fetch size configurable in JDBCIn...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4617


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4617: [FLINK-7556] Fix fetch size configurable in JDBCInputForm...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4617
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---