You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2023/01/13 04:53:51 UTC

[GitHub] [logging-log4j2] jvz commented on pull request #1199: LOG4J2-3228 - Remove support for java.io.Serializable

jvz commented on PR #1199:
URL: https://github.com/apache/logging-log4j2/pull/1199#issuecomment-1381313773

   Alright, @garydgregory, I've removed the unnecessary generic parameter. However, this raises a cleanup issue: we now have `AbstractLayout` and `AbstractStringLayout` which logically should be merged, but this isn't really that easy to do without making weird classes like `AbstractStringLayout.Serializer2` or breaking backward compatibility. Given the existing tests we have for `EcsLayout`, there's clearly some desire for binary compatibility with basic Log4j2 plugins, and the abstract layout classes are seemingly one of those. What do you think? Should I try to pull up whatever members we can that maintain binary compatibility, or should I just leave it as is?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org