You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org> on 2009/04/29 00:05:30 UTC
[jira] Created: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Refactor JeeConfig into an interface/implementation structure
-------------------------------------------------------------
Key: VELTOOLS-116
URL: https://issues.apache.org/jira/browse/VELTOOLS-116
Project: Velocity Tools
Issue Type: Improvement
Components: VelocityView
Affects Versions: 2.0
Reporter: Antonio Petrelli
It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Bubna resolved VELTOOLS-116.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0
Thanks, Antonio!
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Fix For: 2.0
>
> Attachments: veltools-jeeconfig-patch.diff, veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated VELTOOLS-116:
--------------------------------------
Attachment: veltools-jeeconfig-patch.diff
Added patch for JeeConfig structure.
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Attachments: veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704352#action_12704352 ]
Antonio Petrelli commented on VELTOOLS-116:
-------------------------------------------
Agreed. Let me work on it and you will get even Javadocs :-D
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Attachments: veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated VELTOOLS-116:
--------------------------------------
Attachment: veltools-jeeconfig-patch.diff
Attached new version of the patch. Removed extras, added javadocs, changed names.
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Attachments: veltools-jeeconfig-patch.diff, veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704359#action_12704359 ]
Nathan Bubna commented on VELTOOLS-116:
---------------------------------------
Great! Ccan i ask a small, additional favor and have you name the implementations: JeeServletConfig, JeeFilterConfig and JeeContextConfig? I like pretty names when possible, and "Impl" is always extraneous. :)
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Attachments: veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704155#action_12704155 ]
Nathan Bubna commented on VELTOOLS-116:
---------------------------------------
Good idea, though you've got some extras in that diff for VelocityView and VelocityViewServlet... :)
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Attachments: veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-116) Refactor JeeConfig into an
interface/implementation structure
Posted by "Antonio Petrelli (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELTOOLS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704363#action_12704363 ]
Antonio Petrelli commented on VELTOOLS-116:
-------------------------------------------
Ok. I already changed the names locally, I'll try to create the patch tomorrow (it's midnight here :-S )
> Refactor JeeConfig into an interface/implementation structure
> -------------------------------------------------------------
>
> Key: VELTOOLS-116
> URL: https://issues.apache.org/jira/browse/VELTOOLS-116
> Project: Velocity Tools
> Issue Type: Improvement
> Components: VelocityView
> Affects Versions: 2.0
> Reporter: Antonio Petrelli
> Attachments: veltools-jeeconfig-patch.diff
>
>
> It seems that JeeConfig is not extendable. I have thought of an interface/implementation architecture, with three implementatins (for ServletConfig, ServletContext and FilterConfig).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org