You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/02 02:14:43 UTC
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #549: Improve code coverage of zookeeper config center
hxmhlt commented on a change in pull request #549:
URL: https://github.com/apache/dubbo-go/pull/549#discussion_r433583313
##########
File path: config_center/zookeeper/impl.go
##########
@@ -81,32 +79,6 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu
}
-func newMockZookeeperDynamicConfiguration(url *common.URL, opts ...zookeeper.Option) (*zk.TestCluster, *zookeeperDynamicConfiguration, error) {
- c := &zookeeperDynamicConfiguration{
- url: url,
- rootPath: "/" + url.GetParam(constant.CONFIG_NAMESPACE_KEY, config_center.DEFAULT_GROUP) + "/config",
- }
- var (
- tc *zk.TestCluster
- err error
- )
- tc, c.client, _, err = zookeeper.NewMockZookeeperClient("test", 15*time.Second, opts...)
- if err != nil {
Review comment:
zookeeper.NewMockZookeeperClient may delete?
##########
File path: config_center/zookeeper/impl.go
##########
@@ -81,32 +79,6 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu
}
-func newMockZookeeperDynamicConfiguration(url *common.URL, opts ...zookeeper.Option) (*zk.TestCluster, *zookeeperDynamicConfiguration, error) {
- c := &zookeeperDynamicConfiguration{
- url: url,
- rootPath: "/" + url.GetParam(constant.CONFIG_NAMESPACE_KEY, config_center.DEFAULT_GROUP) + "/config",
- }
- var (
- tc *zk.TestCluster
- err error
- )
- tc, c.client, _, err = zookeeper.NewMockZookeeperClient("test", 15*time.Second, opts...)
- if err != nil {
- logger.Errorf("mock zookeeper client start error ,error message is %v", err)
- return tc, c, err
- }
- c.wg.Add(1)
- go zookeeper.HandleClientRestart(c)
-
Review comment:
Is zookeeper.HandleClientRestart(c) coveraged ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org