[jira] [Commented] (HDFS-17378) Missing operationType for some operations in authorizer

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023948#comment-18023948 ] 

ASF GitHub Bot commented on HDFS-17378:
---------------------------------------

github-actions[bot] commented on PR #6553:
URL: https://github.com/apache/hadoop/pull/6553#issuecomment-3354232132

   We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
   Thanks all for your contribution.




> Missing operationType for some operations in authorizer
> -------------------------------------------------------
>
>                 Key: HDFS-17378
>                 URL: https://issues.apache.org/jira/browse/HDFS-17378
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.3.6
>            Reporter: Sebastian Bernauer
>            Priority: Minor
>              Labels: pull-request-available
>
> In HDFS-14743 the operationType was implemented as a thread-local, which requires the caller to set the thread-local before calling the {{AccessControlEnforcer}} interface.
> Most operations will set the operationType to a String, but some operations set it to {{{}null{}}}.
> This causes the FSPermissionChecker to always call the old (deprecated) {{AccessControlEnforcer.checkPermission}} API (see
> [https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java#L431])
> Instead of setting the operationType to {{null}} (e.g. [here|https://github.com/apache/hadoop/blob/50d256ef3c2531563bc6ba96dec6b78e154b4697/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L2767]) we should set the correct value.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org