You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/11 18:31:59 UTC

[GitHub] [hbase] ndimiduk commented on a change in pull request #3252: HBASE-25862 update reference guide for log4j2.xml

ndimiduk commented on a change in pull request #3252:
URL: https://github.com/apache/hbase/pull/3252#discussion_r630427184



##########
File path: src/main/asciidoc/_chapters/configuration.adoc
##########
@@ -636,7 +636,9 @@ read by HBase daemons on startup.
 Changes here will require a cluster restart for HBase to notice the change.
 
 [[log4j]]
-=== _log4j.properties_
+=== _log4j2.xml_
+
+Since version 3.0.0, HBase has upgraded to Log4j2, so the configuration file name and format has changed.Read more in link:https://logging.apache.org/log4j/2.x/index.html[Apache Log4j2].

Review comment:
       Needs a space after the end of the first sentence. `s/changed.Read/changed. Read/`. Otherwise, looks good to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org