You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "qqu0127 (via GitHub)" <gi...@apache.org> on 2023/05/05 15:30:32 UTC

[GitHub] [helix] qqu0127 commented on pull request #2463: Initial commit for capacity based throttler for state transition control

qqu0127 commented on PR #2463:
URL: https://github.com/apache/helix/pull/2463#issuecomment-1536429206

   > I was got a wrong impression on the these throttler will be in intermediateStage for throttling.
   > 
   > If it is only used in WAGED, I would suggest to name it "Filter" instead of throttler. Because there is already a state transition throttler in intermediateStage.
   
   This will be applied to intermediateStage. It is NOT reserved for WAGED, it can apply to any rebalancer. Because the state transition is in planning phase (how we schedule movement), which is after the idealstate is calculated.
   In my opinion, this will be merged with the state transition throttler eventually


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org