You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "NorthDataEngineer (via GitHub)" <gi...@apache.org> on 2023/08/30 13:19:26 UTC
[GitHub] [inlong] NorthDataEngineer opened a new pull request, #8822: Inlong #7056 Manager FlinkConfiguration add setFlinkConfig-set flink config from Map before getFlinkConfig,not only get default flink config from flink-sort-plugin.properties
NorthDataEngineer opened a new pull request, #8822:
URL: https://github.com/apache/inlong/pull/8822
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #XYZ
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-7056][Manager] Support add more properties for submitting flink job [inlong]
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng closed pull request #8822: [INLONG-7056][Manager] Support add more properties for submitting flink job
URL: https://github.com/apache/inlong/pull/8822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #8822: [INLONG-7056][Manager] Support add more properties for submitting flink job
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #8822:
URL: https://github.com/apache/inlong/pull/8822#discussion_r1312676682
##########
inlong-manager/manager-plugins/base/src/main/java/org/apache/inlong/manager/plugin/util/FlinkConfiguration.java:
##########
@@ -83,6 +85,30 @@ private String formatPath() throws Exception {
return confPath;
}
+ /**
+ * set flink config from Map k-v
+ */
+ public void setFlinkConfig(Map<String, String> flinkConfigMap) throws Exception {
Review Comment:
Great, but how to use this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-7056][Manager] Support add more properties for submitting flink job [inlong]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8822:
URL: https://github.com/apache/inlong/pull/8822#issuecomment-1788273589
This PR is stale because it has been open for 60 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-7056][Manager] Support add more properties for submitting flink job [inlong]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8822:
URL: https://github.com/apache/inlong/pull/8822#issuecomment-2357336554
This PR is stale because it has been open for 60 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-7056][Manager] Support add more properties for submitting flink job [inlong]
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on PR #8822:
URL: https://github.com/apache/inlong/pull/8822#issuecomment-2658609013
This PR will be closed since it has been open for 1 year with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org