You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/16 09:57:30 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7095: fix guestOsMapper and move mapping code to latest upgrade

weizhouapache commented on code in PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#discussion_r1071041529


##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41500to41510.java:
##########
@@ -250,130 +249,6 @@ private void correctGuestOsNames(final Connection conn) {
         guestOsMapper.updateGuestOsNameFromMapping("OpenSUSE Linux (32 bit)", mapping);
     }

Review Comment:
   double-checked just now.
   
   both `addGuestOsAndHypervisorMappings` and `updateGuestOsIdInHypervisorMapping` call the method `getGuestOsId`, they need to be moved.
   
   `updateGuestOsNameFromMapping` is correct. sorry for my mistake
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org