[GitHub] [storm] Ethanlm commented on a change in pull request #3030: [STORM-3411] add parent dir name to downloaded worker log file

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #3030: [STORM-3411] add parent dir name to downloaded worker log file
URL: https://github.com/apache/storm/pull/3030#discussion_r299703066
 
 

 ##########
 File path: storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogviewerResponseBuilder.java
 ##########
 @@ -75,16 +75,26 @@ public static Response buildSuccessJsonResponse(Object entity, String callback,
     /**
      * Build a Response object representing download a file.
      *
+     * @param host host address
      * @param file file to download
      */
-    public static Response buildDownloadFile(File file, Meter numFileDownloadExceptions) throws IOException {
+    public static Response buildDownloadFile(String host, File file, Meter numFileDownloadExceptions) throws IOException {
         try {
             // do not close this InputStream in method: it will be used from jetty server
 
 Review comment:
   This comment is misplaced. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services