You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/01/27 08:27:51 UTC

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #944: DISPATCH-1870 - gRPC system test

jiridanek commented on a change in pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#discussion_r565112575



##########
File path: README
##########
@@ -80,6 +80,10 @@ To install pip and Quart
  - python3 get-pip.py
  - pip3 install --user quart
 
+The gRPC system tests (tests/system_tests_grpc.py) use grpcio and protobuf modules.
+To install them use:
+  - pip3 install --user grpcio protobuf

Review comment:
       looks good; that does not add the copyright header, though, if I understand correctly
   
   ok, I see you excluded the generated files from rat check




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org