You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Matthew Hatem <mh...@gmail.com> on 2011/08/16 21:14:26 UTC
Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
Review request for shindig and Ryan Baxter.
Summary
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
> On 2011-08-19 13:21:02, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js, line 9
> > <https://reviews.apache.org/r/1533/diff/4/?file=33665#file33665line9>
> >
> > You need to change the name of these as well
Done
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1547
-----------------------------------------------------------
On 2011-08-19 13:56:41, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 13:56:41)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1547
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js
<https://reviews.apache.org/r/1533/#comment3520>
You need to change the name of these as well
- Ryan
On 2011-08-19 01:53:08, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 01:53:08)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
(Updated 2011-08-21 03:17:07.524460)
Review request for shindig and Ryan Baxter.
Summary
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
This addresses bug https://reviews.apache.org/r/1533/.
https://issues.apache.org/jira/browse/https://reviews.apache.org/r/1533/
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1159890
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1159890
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1587
-----------------------------------------------------------
Ship it!
Committed revision 1159925.
Please close the JIRA and attach the patch to it.
Also if you add JIRA to the bugs section of the review it will post all the updates to the JIRA, connecting the 2.
- Ryan
On 2011-08-20 17:31:02, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-20 17:31:02)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1159890
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1159890
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1159890
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1159890
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1159890
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1159890
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1159890
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
(Updated 2011-08-20 17:31:02.792917)
Review request for shindig and Ryan Baxter.
Changes
-------
Sync'd and updated patch.
Summary
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1159890
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1159890
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1159890
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1584
-----------------------------------------------------------
Looks good, could you make sure content/samplecontainer/examples/conservcontainer/index.html is up to date and regenerate the patch? I am getting errors when applying it.
- Ryan
On 2011-08-19 13:56:41, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 13:56:41)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
(Updated 2011-08-19 13:56:41.695019)
Review request for shindig and Ryan Baxter.
Summary
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
(Updated 2011-08-19 01:53:08.369683)
Review request for shindig and Ryan Baxter.
Changes
-------
Updated patch that addresses all comments.
Summary
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
(Updated 2011-08-19 00:33:54.116967)
Review request for shindig and Ryan Baxter.
Changes
-------
I will have an updated patch, with gadget level show/hideActionHandler demo, soon.
Summary
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew
Re: Review Request: Fixes to actions feature to match spec (runAction
and registerXHandler).
Posted by Henry Saputra <he...@gmail.com>.
But at least we can fix the example code right?
Matthew can file issue for Opensocial spec change just to fix the typo in
the example to match the API name for 2.0.
Henry
On Friday, August 19, 2011, Ryan J Baxter <rj...@us.ibm.com> wrote:
> Henry we cant change the API name in the spec at this point. We will fix
> them in the container in Next. Like you said we should create an issue
> against the spec to track it.
>
> -Ryan
>
> Email: rjbaxter@us.ibm.com
> Phone: 978-899-3041
> developerWorks Profile
>
>
>
> From: Henry Saputra <he...@gmail.com>
> To: "dev@shindig.apache.org" <de...@shindig.apache.org>,
> Cc: Ryan Baxter <rb...@gmail.com>, Matthew Hatem
> <mh...@gmail.com>
> Date: 08/19/2011 11:40 AM
> Subject: Re: Review Request: Fixes to actions feature to match spec
> (runAction and registerXHandler).
>
>
>
> Hi Matthew,
>
> Yes, please open defect and provide patch if you can to fix the example
> code
> in the spec.
>
> I think you are one of the champions for this feature right? I am not sure
> if we could change the name of the API instead at this point.
> Mark W is probably the best person to answer this. If we can't change the
> spec to match the API names then the ref implementation in Shindig should
> follow it till we change it in Next spec release.
>
> - Henry
>
> On Friday, August 19, 2011, Matthew Hatem <mh...@gmail.com> wrote:
>>
>>
>>> On 2011-08-17 22:14:53, Ryan Baxter wrote:
>>> >
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js
> ,
> line 251
>>> > <
> https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251>
>>> >
>>> > Same here the function is called registerHidActionsListener
>>>
>>> Matthew Hatem wrote:
>>> The Core Gadget spec is wrong and inconsistent. The API should be
> symmetric with the CommonContainer API which uses 'Handler' not
> 'Listener'.
>>>
>>> Also, the examples in the Core Gadget spec uses 'Handler'
>>>
>>> var myShowActionsHandler = function(actionObjs){
>>> // draw the UI, toolbars menus, etc
>>> // to do the invocation of the action, call the following
> API:
>>> // gadgets.actions.runAction(actionObjs[0].id);
>>> }
>>> gadgets.actions.registerShowActionsHandler(myShowActionHandler);
>>>
>>> Henry Saputra wrote:
>>> So either we change the spec or change this code to match the spec.
> Even though its maybe wrong but thats what in the final spec.
>>>
>>> I would prefer to have it wrong here to at least match the spec.
> From
> gadgets point of view I think its ok to be called xxxListener because it
> listen actions event from container.
>>
>> I would prefer to change the spec but I understand if it's too late.
>>
>> I can change 'Handler' to 'Listener' now.
>>
>> Should I create a defect to update the example code in the spec.
>>
>>
>> - Matthew
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/1533/#review1512
>> -----------------------------------------------------------
>>
>>
>> On 2011-08-19 13:56:41, Matthew Hatem wrote:
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/1533/
>>> -----------------------------------------------------------
>>>
>>> (Updated 2011-08-19 13:56:41)
>>>
>>>
>>> Review request for shindig and Ryan Baxter.
>>>
>>>
>>> Summary
>>> -------
>>>
>>> Fixes to actions feature to match spec (runAction and
> registerXHandler).
>>>
>>> JIRA posted:
>>> https://issues.apache.org/jira/browse/SHINDIG-1575
>>>
>>>
>>> Diffs
>>> -----
>>>
>>>
>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js1157952
>
>>>
> http://svn.apache.org/repos/asf/shindig/trunk/ <
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html1157952
>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xmlPRE-CREATION
>
>>>
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js1157952
>
>>>
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js1157952
>
>>>
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml1157952
>
>>>
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js1157952
>
>>>
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js1157952
>
>>>
>>> Diff: https://reviews.apache.org/r/1533/diff
>>>
>>>
>>> Testing
>>> -------
>>>
>>> All JsUnit tests pass
>>>
>>>
>>> Thanks,
>>>
>>> Matthew
>>>
>>>
>>
>>
>
>
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Ryan J Baxter <rj...@us.ibm.com>.
Henry we cant change the API name in the spec at this point. We will fix
them in the container in Next. Like you said we should create an issue
against the spec to track it.
-Ryan
Email: rjbaxter@us.ibm.com
Phone: 978-899-3041
developerWorks Profile
From: Henry Saputra <he...@gmail.com>
To: "dev@shindig.apache.org" <de...@shindig.apache.org>,
Cc: Ryan Baxter <rb...@gmail.com>, Matthew Hatem
<mh...@gmail.com>
Date: 08/19/2011 11:40 AM
Subject: Re: Review Request: Fixes to actions feature to match spec
(runAction and registerXHandler).
Hi Matthew,
Yes, please open defect and provide patch if you can to fix the example
code
in the spec.
I think you are one of the champions for this feature right? I am not sure
if we could change the name of the API instead at this point.
Mark W is probably the best person to answer this. If we can't change the
spec to match the API names then the ref implementation in Shindig should
follow it till we change it in Next spec release.
- Henry
On Friday, August 19, 2011, Matthew Hatem <mh...@gmail.com> wrote:
>
>
>> On 2011-08-17 22:14:53, Ryan Baxter wrote:
>> >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js
,
line 251
>> > <
https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251>
>> >
>> > Same here the function is called registerHidActionsListener
>>
>> Matthew Hatem wrote:
>> The Core Gadget spec is wrong and inconsistent. The API should be
symmetric with the CommonContainer API which uses 'Handler' not
'Listener'.
>>
>> Also, the examples in the Core Gadget spec uses 'Handler'
>>
>> var myShowActionsHandler = function(actionObjs){
>> // draw the UI, toolbars menus, etc
>> // to do the invocation of the action, call the following
API:
>> // gadgets.actions.runAction(actionObjs[0].id);
>> }
>> gadgets.actions.registerShowActionsHandler(myShowActionHandler);
>>
>> Henry Saputra wrote:
>> So either we change the spec or change this code to match the spec.
Even though its maybe wrong but thats what in the final spec.
>>
>> I would prefer to have it wrong here to at least match the spec.
From
gadgets point of view I think its ok to be called xxxListener because it
listen actions event from container.
>
> I would prefer to change the spec but I understand if it's too late.
>
> I can change 'Handler' to 'Listener' now.
>
> Should I create a defect to update the example code in the spec.
>
>
> - Matthew
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/#review1512
> -----------------------------------------------------------
>
>
> On 2011-08-19 13:56:41, Matthew Hatem wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/1533/
>> -----------------------------------------------------------
>>
>> (Updated 2011-08-19 13:56:41)
>>
>>
>> Review request for shindig and Ryan Baxter.
>>
>>
>> Summary
>> -------
>>
>> Fixes to actions feature to match spec (runAction and
registerXHandler).
>>
>> JIRA posted:
>> https://issues.apache.org/jira/browse/SHINDIG-1575
>>
>>
>> Diffs
>> -----
>>
>>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xmlPRE-CREATION
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js1157952
>>
>> Diff: https://reviews.apache.org/r/1533/diff
>>
>>
>> Testing
>> -------
>>
>> All JsUnit tests pass
>>
>>
>> Thanks,
>>
>> Matthew
>>
>>
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction
and registerXHandler).
Posted by Henry Saputra <he...@gmail.com>.
Hi Matthew,
Yes, please open defect and provide patch if you can to fix the example code
in the spec.
I think you are one of the champions for this feature right? I am not sure
if we could change the name of the API instead at this point.
Mark W is probably the best person to answer this. If we can't change the
spec to match the API names then the ref implementation in Shindig should
follow it till we change it in Next spec release.
- Henry
On Friday, August 19, 2011, Matthew Hatem <mh...@gmail.com> wrote:
>
>
>> On 2011-08-17 22:14:53, Ryan Baxter wrote:
>> >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js,
line 251
>> > <https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251>
>> >
>> > Same here the function is called registerHidActionsListener
>>
>> Matthew Hatem wrote:
>> The Core Gadget spec is wrong and inconsistent. The API should be
symmetric with the CommonContainer API which uses 'Handler' not 'Listener'.
>>
>> Also, the examples in the Core Gadget spec uses 'Handler'
>>
>> var myShowActionsHandler = function(actionObjs){
>> // draw the UI, toolbars menus, etc
>> // to do the invocation of the action, call the following API:
>> // gadgets.actions.runAction(actionObjs[0].id);
>> }
>> gadgets.actions.registerShowActionsHandler(myShowActionHandler);
>>
>> Henry Saputra wrote:
>> So either we change the spec or change this code to match the spec.
Even though its maybe wrong but thats what in the final spec.
>>
>> I would prefer to have it wrong here to at least match the spec. From
gadgets point of view I think its ok to be called xxxListener because it
listen actions event from container.
>
> I would prefer to change the spec but I understand if it's too late.
>
> I can change 'Handler' to 'Listener' now.
>
> Should I create a defect to update the example code in the spec.
>
>
> - Matthew
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/#review1512
> -----------------------------------------------------------
>
>
> On 2011-08-19 13:56:41, Matthew Hatem wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/1533/
>> -----------------------------------------------------------
>>
>> (Updated 2011-08-19 13:56:41)
>>
>>
>> Review request for shindig and Ryan Baxter.
>>
>>
>> Summary
>> -------
>>
>> Fixes to actions feature to match spec (runAction and registerXHandler).
>>
>> JIRA posted:
>> https://issues.apache.org/jira/browse/SHINDIG-1575
>>
>>
>> Diffs
>> -----
>>
>>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xmlPRE-CREATION
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js1157952
>>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js1157952
>>
>> Diff: https://reviews.apache.org/r/1533/diff
>>
>>
>> Testing
>> -------
>>
>> All JsUnit tests pass
>>
>>
>> Thanks,
>>
>> Matthew
>>
>>
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js, line 251
> > <https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251>
> >
> > Same here the function is called registerHidActionsListener
>
> Matthew Hatem wrote:
> The Core Gadget spec is wrong and inconsistent. The API should be symmetric with the CommonContainer API which uses 'Handler' not 'Listener'.
>
> Also, the examples in the Core Gadget spec uses 'Handler'
>
> var myShowActionsHandler = function(actionObjs){
> // draw the UI, toolbars menus, etc
> // to do the invocation of the action, call the following API:
> // gadgets.actions.runAction(actionObjs[0].id);
> }
> gadgets.actions.registerShowActionsHandler(myShowActionHandler);
>
> Henry Saputra wrote:
> So either we change the spec or change this code to match the spec. Even though its maybe wrong but thats what in the final spec.
>
> I would prefer to have it wrong here to at least match the spec. From gadgets point of view I think its ok to be called xxxListener because it listen actions event from container.
I would prefer to change the spec but I understand if it's too late.
I can change 'Handler' to 'Listener' now.
Should I create a defect to update the example code in the spec.
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1512
-----------------------------------------------------------
On 2011-08-19 13:56:41, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 13:56:41)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, line 90
> > <https://reviews.apache.org/r/1533/diff/2/?file=32937#file32937line90>
> >
> > Is it possible for actions not to have any items in it?
no
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, line 174
> > <https://reviews.apache.org/r/1533/diff/2/?file=32937#file32937line174>
> >
> > Is it possible for actions not to have actions in it?
no
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, line 199
> > <https://reviews.apache.org/r/1533/diff/2/?file=32937#file32937line199>
> >
> > Small nit would be nice to add a comment there, the rest of the code is nicely commented
done.
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js, line 251
> > <https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251>
> >
> > Same here the function is called registerHidActionsListener
The Core Gadget spec is wrong and inconsistent. The API should be symmetric with the CommonContainer API which uses 'Handler' not 'Listener'.
Also, the examples in the Core Gadget spec uses 'Handler'
var myShowActionsHandler = function(actionObjs){
// draw the UI, toolbars menus, etc
// to do the invocation of the action, call the following API:
// gadgets.actions.runAction(actionObjs[0].id);
}
gadgets.actions.registerShowActionsHandler(myShowActionHandler);
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, line 561
> > <https://reviews.apache.org/r/1533/diff/2/?file=32941#file32941line561>
> >
> > This is invalid, put takes 2 parameters. Maybe you meant for showActionListeners to be an array?
should be push(), sorry
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, line 584
> > <https://reviews.apache.org/r/1533/diff/2/?file=32941#file32941line584>
> >
> > Same here put takes 2 parameters
should be push(), sorry
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1512
-----------------------------------------------------------
On 2011-08-16 19:17:05, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-16 19:17:05)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Henry Saputra <hs...@apache.org>.
> On 2011-08-17 22:14:53, Ryan Baxter wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js, line 251
> > <https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251>
> >
> > Same here the function is called registerHidActionsListener
>
> Matthew Hatem wrote:
> The Core Gadget spec is wrong and inconsistent. The API should be symmetric with the CommonContainer API which uses 'Handler' not 'Listener'.
>
> Also, the examples in the Core Gadget spec uses 'Handler'
>
> var myShowActionsHandler = function(actionObjs){
> // draw the UI, toolbars menus, etc
> // to do the invocation of the action, call the following API:
> // gadgets.actions.runAction(actionObjs[0].id);
> }
> gadgets.actions.registerShowActionsHandler(myShowActionHandler);
So either we change the spec or change this code to match the spec. Even though its maybe wrong but thats what in the final spec.
I would prefer to have it wrong here to at least match the spec. From gadgets point of view I think its ok to be called xxxListener because it listen actions event from container.
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1512
-----------------------------------------------------------
On 2011-08-19 00:33:54, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-19 00:33:54)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/#review1512
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js
<https://reviews.apache.org/r/1533/#comment3460>
Is it possible for actions not to have any items in it?
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js
<https://reviews.apache.org/r/1533/#comment3461>
Is it possible for actions not to have actions in it?
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js
<https://reviews.apache.org/r/1533/#comment3455>
Small nit would be nice to add a comment there, the rest of the code is nicely commented
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml
<https://reviews.apache.org/r/1533/#comment3462>
Can we add show and hide action listeners to the sample?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js
<https://reviews.apache.org/r/1533/#comment3456>
The function is called registerShowActionListener in the spec
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js
<https://reviews.apache.org/r/1533/#comment3457>
Same here the function is called registerHidActionsListener
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/1533/#comment3458>
This is invalid, put takes 2 parameters. Maybe you meant for showActionListeners to be an array?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/1533/#comment3459>
Same here put takes 2 parameters
- Ryan
On 2011-08-16 19:17:05, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1533/
> -----------------------------------------------------------
>
> (Updated 2011-08-16 19:17:05)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Summary
> -------
>
> Fixes to actions feature to match spec (runAction and registerXHandler).
>
> JIRA posted:
> https://issues.apache.org/jira/browse/SHINDIG-1575
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
>
> Diff: https://reviews.apache.org/r/1533/diff
>
>
> Testing
> -------
>
> All JsUnit tests pass
>
>
> Thanks,
>
> Matthew
>
>
Re: Review Request: Fixes to actions feature to match spec (runAction and
registerXHandler).
Posted by Matthew Hatem <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1533/
-----------------------------------------------------------
(Updated 2011-08-16 19:17:05.813686)
Review request for shindig and Ryan Baxter.
Changes
-------
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
Summary (updated)
-------
Fixes to actions feature to match spec (runAction and registerXHandler).
JIRA posted:
https://issues.apache.org/jira/browse/SHINDIG-1575
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html 1157952
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js 1157952
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js 1157952
Diff: https://reviews.apache.org/r/1533/diff
Testing
-------
All JsUnit tests pass
Thanks,
Matthew