You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "EchoLee5 (via GitHub)" <gi...@apache.org> on 2023/05/22 08:36:26 UTC
[GitHub] [seatunnel] EchoLee5 opened a new pull request, #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
EchoLee5 opened a new pull request, #4802:
URL: https://github.com/apache/seatunnel/pull/4802
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
When writing to the target table fails for some reason, for example, the target table does not exist.
The internal call sequence of JdbcOutputFormat is:
JdbcOutputFormat#flush(throws IOException) --> JdbcOutputFormat#close --> JdbcOutputFormat#flush(throws RuntimeException).
Will not call the close method of the database connection, when the restart strategy is fixeddelay, maxNumberRestartAttempts is Integer.MAX, this will cause the number of database connections to continue to rise and reach the limit.
`2022-12-07 10:49:32,050 ERROR org.apache.flink.connector.jdbc.internal.JdbcBatchingOutputFormat [] - JDBC executeBatch error, retry times = 3
java.sql.BatchUpdateException: ORA-00942: table or view does not exist
Caused by: java.sql.SQLException: Listener refused the connection with the following error:
ORA-12519, TNS:no appropriate service handler found `
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1558463147
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EchoLee5 commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "EchoLee5 (via GitHub)" <gi...@apache.org>.
EchoLee5 commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1559073077
> LGTM， Let's wait the CI complete.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EchoLee5 commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "EchoLee5 (via GitHub)" <gi...@apache.org>.
EchoLee5 commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1559073862
> LGTM
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1645045489
CI error is not related to this PR. Thanks for your contribute!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X merged pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X merged PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] Hisoka-X commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1558320364
@ic4y PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1558919527
LGTM， Let's wait the CI complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EchoLee5 commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "EchoLee5 (via GitHub)" <gi...@apache.org>.
EchoLee5 commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1556813624
cc @rewerma Please give me a review, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1576394962
Retry CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4802: [Hotfix][Connector][Jdbc] Fix the problem of JdbcOutputFormat databas…
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4802:
URL: https://github.com/apache/seatunnel/pull/4802#issuecomment-1610605322
Please rebase the dev branch, this will resolve the CI problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org