[jira] [Commented] (ORC-267) Restore NOTICES and LICENSE to binary tarball

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277124#comment-16277124 ] 

ASF GitHub Bot commented on ORC-267:
------------------------------------

Github user jcrist commented on a diff in the pull request:

    https://github.com/apache/orc/pull/193#discussion_r154717285
  
    --- Diff: CMakeLists.txt ---
    @@ -105,6 +105,11 @@ INCLUDE(ThirdpartyToolchain)
     set (EXAMPLE_DIRECTORY ${CMAKE_SOURCE_DIR}/examples)
     
     add_subdirectory(c++)
    +
    +install(
    +  FILES LICENSE NOTICE
    +  DESTINATION .)
    --- End diff --
    
    If I do `make install`, these just get placed in my root directory. Other apache projects (e.g. arrow, parquet-cpp) don't install the `LICENSE` or `NOTICE` (the header files all have the license information), so why is this needed? This is why I removed these in #192, sorry if there was a good reason for installing these.


> Restore NOTICES and LICENSE to binary tarball
> ---------------------------------------------
>
>                 Key: ORC-267
>                 URL: https://issues.apache.org/jira/browse/ORC-267
>             Project: ORC
>          Issue Type: Task
>            Reporter: Owen O'Malley
>            Assignee: Deepak Majeti
>             Fix For: 1.5.0
>
>
> We need to distribute the NOTICE and LICENSE file with the binary distribution, but they were removed by ORC-266.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)