You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/19 09:59:42 UTC
[GitHub] [flink] zjuwangg opened a new pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
zjuwangg opened a new pull request #15283:
URL: https://github.com/apache/flink/pull/15283
## What is the purpose of the change
*fix unstable JoinJsonPlanITCase*
## Brief change log
- as title.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802759688
> And what is the root cause of the issue?
No limit parallelism causing insufficient number of network buffers in LocalExecutionEnvironment in certain situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802706232
what kind of failure have you observed, and why do you believe this to fix the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802718888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b1cc42491451a915ed8f816fed15a974765daae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b1cc42491451a915ed8f816fed15a974765daae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b1cc42491451a915ed8f816fed15a974765daae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802769406
> No limit parallelism causing insufficient number of network buffers in LocalExecutionEnvironment in certain situation.
And what are those certain situations? If the parallelism is a fixed value (because it runs on CI with a supposedly constant number of CPU cores) and the number of required buffers is also a fixed value (because the job didn't change), then why is it failing _sometimes_?
Furthermore, why is only this test being touched? Why are other tests in this class, and by extension other JsonPlanTestBase sub-classes, not affected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802718888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b1cc42491451a915ed8f816fed15a974765daae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15042",
"triggerID" : "0b1cc42491451a915ed8f816fed15a974765daae",
"triggerType" : "PUSH"
}, {
"hash" : "d218f580f3d2b097cc8901a82db600a9df0be810",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d218f580f3d2b097cc8901a82db600a9df0be810",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b1cc42491451a915ed8f816fed15a974765daae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15042)
* d218f580f3d2b097cc8901a82db600a9df0be810 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802727673
And what is the root cause of the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802846504
Close this pr temporally until we exactly know why and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802718888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b1cc42491451a915ed8f816fed15a974765daae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15042",
"triggerID" : "0b1cc42491451a915ed8f816fed15a974765daae",
"triggerType" : "PUSH"
}, {
"hash" : "d218f580f3d2b097cc8901a82db600a9df0be810",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15054",
"triggerID" : "d218f580f3d2b097cc8901a82db600a9df0be810",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b1cc42491451a915ed8f816fed15a974765daae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15042)
* d218f580f3d2b097cc8901a82db600a9df0be810 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15054)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802706608
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0b1cc42491451a915ed8f816fed15a974765daae (Fri Mar 19 10:02:36 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg edited a comment on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zjuwangg edited a comment on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802711896
> what kind of failure have you observed, and why do you believe this to fix the issue?
hi @zentol The detailed error is https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15017&view=logs&j=e25d5e7e-2a9c-5589-4940-0b638d75a414&t=a6e0f756-5bb9-5ea8-a468-5f60db442a29
Fatal errror is as following:
> Insufficient number of network buffers: required 33, but only 2 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'.
at org.apache.flink.runtime.io.network.buffer.NetworkBufferPool.internalCreateBufferPool(NetworkBufferPool.java:372)
By change the parallelism, I think this should improve the test stablity.
I'll add comments here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802786244
> And what are those certain situations? If the parallelism is a fixed value (because it runs on CI with a supposedly constant number of CPU cores) and the number of required buffers is also a fixed value (because the job didn't change), then why is it failing _sometimes_?
It's very good question.
I don't known too much about runtime resource allocate behavior. Is there more experience or advice to dig into deeper?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg closed pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zjuwangg closed pull request #15283:
URL: https://github.com/apache/flink/pull/15283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802769406
> No limit parallelism causing insufficient number of network buffers in LocalExecutionEnvironment in certain situation.
And what are those certain situations? If the parallelism is a fixed value (because it runs on CI) and the number of required buffers is also a fixed value (because the job didn't change), then why is it failing _sometimes_?
Furthermore, why is only this test being touched? Why are other tests in this class, and by extension other JsonPlanTestBase sub-classes, not affected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802711896
> what kind of failure have you observed, and why do you believe this to fix the issue?
hi @zentol The detailed error is https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15017&view=logs&j=e25d5e7e-2a9c-5589-4940-0b638d75a414&t=a6e0f756-5bb9-5ea8-a468-5f60db442a29
Fatal errror is as following:
`Insufficient number of network buffers: required 33, but only 2 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'.
at org.apache.flink.runtime.io.network.buffer.NetworkBufferPool.internalCreateBufferPool(NetworkBufferPool.java:372)
`
By change the parallelism, I think this should improve the test stablity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802706232
what kind of failure have you observed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #15283: [hotfix] fix unstable JoinJsonPlanITCase
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #15283:
URL: https://github.com/apache/flink/pull/15283#issuecomment-802873529
TBH I wouldn't know where to look myself, but it is very odd that this started to happen all of a sudden, and there appear to be several instances. A ticket has been filed for this issue: FLINK-21878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org