You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jrmccluskey (via GitHub)" <gi...@apache.org> on 2026/01/13 20:55:04 UTC

[PR] Remove standalone uses of the apitools HttpError class [beam]

jrmccluskey opened a new pull request, #37296:
URL: https://github.com/apache/beam/pull/37296

   Removes outdated/standalone usages of the apitools HttpError exception class.
   
   Part of #35611
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #37296:
URL: https://github.com/apache/beam/pull/37296#discussion_r2691199613


##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
         # e.code.value contains the numeric http status code.
         service_call_metric.call(e.code.value)
         raise
-      except HttpError as e:
-        service_call_metric.call(e)
-        raise

Review Comment:
   Yeah these clients *shouldn't* be returning these exception types anyway, the GoogleAPICallError should be used instead. We could add a broader exception catch here if we wanted to make absolutely sure though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37296:
URL: https://github.com/apache/beam/pull/37296#discussion_r2691725967


##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
         # e.code.value contains the numeric http status code.
         service_call_metric.call(e.code.value)
         raise
-      except HttpError as e:
-        service_call_metric.call(e)
-        raise

Review Comment:
   I think it is ok to leave as is if these clients shouldn't return the exception. We can't report the error code correctly with a broader catch anyways.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #37296:
URL: https://github.com/apache/beam/pull/37296#discussion_r2688127712


##########
sdks/python/apache_beam/testing/pipeline_verifiers_test.py:
##########
@@ -122,15 +123,11 @@ def test_file_checksum_matcher_read_failed(self, mock_match):
     self.assertEqual(verifiers.MAX_RETRIES + 1, mock_match.call_count)
 
   @patch.object(GCSFileSystem, 'match')
-  @unittest.skipIf(HttpError is None, 'google-apitools is not installed')
+  @unittest.skipIf(GoogleAPICallError is None, 'google-apitools is not installed')

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   For consistency with other files in this PR, could you update the skip message to `'GCP dependencies are not installed'`?
   
   ```suggestion
     @unittest.skipIf(GoogleAPICallError is None, 'GCP dependencies are not installed')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37296:
URL: https://github.com/apache/beam/pull/37296#issuecomment-3746534971

   ## Summary of Changes
   
   Hello @jrmccluskey, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request modernizes the exception handling mechanisms within the Apache Beam Python SDK, specifically for interactions with Google Cloud Platform (GCP) APIs. It systematically replaces the deprecated `apitools.base.py.exceptions.HttpError` with contemporary and more granular exceptions from the `google.api_core.exceptions` module. This change ensures consistency with current best practices for GCP client libraries and improves the clarity and specificity of error handling across various GCP I/O connectors and testing utilities.
   
   ### Highlights
   
   * **Exception Handling Modernization**: Replaced outdated `apitools.base.py.exceptions.HttpError` with more current and specific exceptions from `google.api_core.exceptions`, primarily `GoogleAPICallError` and `NotFound`.
   * **Code Cleanup**: Removed redundant `except HttpError as e:` blocks where the exceptions were already covered by `ClientError` or `GoogleAPICallError`.
   * **Test Updates**: Updated `unittest.skipIf` conditions and exception assertions in tests to reflect the new exception types.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   
   
   
   
   
   
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #37296:
URL: https://github.com/apache/beam/pull/37296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37296:
URL: https://github.com/apache/beam/pull/37296#discussion_r2690889614


##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
         # e.code.value contains the numeric http status code.
         service_call_metric.call(e.code.value)
         raise
-      except HttpError as e:
-        service_call_metric.call(e)
-        raise

Review Comment:
   Is this safe to remove because we're already not using apitools for these calls?



##########
sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py:
##########
@@ -309,9 +308,6 @@ def process(self, query, *unused_args, **unused_kwargs):
         # e.code.value contains the numeric http status code.
         service_call_metric.call(e.code.value)
         raise
-      except HttpError as e:
-        service_call_metric.call(e)
-        raise

Review Comment:
   Same question applies elsewhere - will this let actual HttpErrors through if we remove it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37296:
URL: https://github.com/apache/beam/pull/37296#issuecomment-3746777569

   Assigning reviewers:
   
   R: @damccorm for label python.
   R: @nielm for label spanner.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove standalone uses of the apitools HttpError class [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #37296:
URL: https://github.com/apache/beam/pull/37296#issuecomment-3746537025

   @gemini-code-assist review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org