You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by kant2002 <gi...@git.apache.org> on 2014/03/19 11:52:32 UTC

[GitHub] cordova-plugin-statusbar pull request: Improved StatusBar support ...

GitHub user kant2002 opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/1

    Improved StatusBar support on Android

    - Added support for the isVisible property fully.
    - Move initialization code after declaration to prevent JS error when plugin pass current statusbar status as response to _ready event

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kant2002/cordova-plugin-statusbar dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
    
----
commit 4375331101bb380761afb2d850f92c3a0addde53
Author: Andrey Kurdyumov <ka...@gmail.com>
Date:   2014-03-19T10:48:59Z

    Moved initialization code after declaration of the StatusBar instance.

commit 4c93db475d7477e76fd3857d9a94ae908f09da7a
Author: Andrey Kurdyumov <ka...@gmail.com>
Date:   2014-03-19T10:50:12Z

    Added support for StatusBar.isVisible on Android

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Improved StatusBar support ...

Posted by shazron <gi...@git.apache.org>.

Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/1#issuecomment-38126580
  
    Pulled in: https://issues.apache.org/jira/browse/CB-6314
    You can close this PR now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Improved StatusBar support ...

Posted by kant2002 <gi...@git.apache.org>.

Github user kant2002 commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/1#issuecomment-38140704
  
    I already saw that code review, just not ready to implement properly as suggested yet. Maybe will handle some of them later, if nobody would take care of them earlier.Thanks for pointing out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Improved StatusBar support ...

Posted by shazron <gi...@git.apache.org>.

Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/1#issuecomment-38126030
  
    Thanks. Be aware however that this will change in the future, see this code review feedback: https://issues.apache.org/jira/browse/CB-5138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-statusbar pull request: Improved StatusBar support ...

Posted by kant2002 <gi...@git.apache.org>.

Github user kant2002 closed the pull request at:

    https://github.com/apache/cordova-plugin-statusbar/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---