[GitHub] [inlong] vernedeng commented on a diff in pull request #7374: [INLONG-7373][Manager] Change the length limitation of InlongStreamId

["vernedeng (via GitHub)" <gi...@apache.org>]

vernedeng commented on code in PR #7374:
URL: https://github.com/apache/inlong/pull/7374#discussion_r1106987732


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sink/SinkRequest.java:
##########
@@ -55,8 +55,8 @@ public abstract class SinkRequest {
 
     @ApiModelProperty("Inlong stream id")
     @NotBlank(groups = {SaveValidation.class, UpdateByKeyValidation.class}, message = "inlongStreamId cannot be blank")
-    @Length(min = 4, max = 100, message = "inlongStreamId length must be between 4 and 100")
-    @Pattern(regexp = "^[a-z0-9_-]{4,100}$", message = "inlongStreamId only supports lowercase letters, numbers, '-', or '_'")
+    @Length(min = 1, max = 100, message = "inlongStreamId length must be between 4 and 100")

Review Comment:
   Fixed, thx



##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/SourceRequest.java:
##########
@@ -55,8 +55,8 @@ public class SourceRequest {
 
     @ApiModelProperty("Inlong stream id")
     @NotBlank(groups = SaveValidation.class, message = "inlongStreamId cannot be blank")
-    @Length(min = 4, max = 100, message = "inlongStreamId length must be between 4 and 100")
-    @Pattern(regexp = "^[a-z0-9_-]{4,100}$", message = "inlongStreamId only supports lowercase letters, numbers, '-', or '_'")
+    @Length(min = 1, max = 100, message = "inlongStreamId length must be between 4 and 100")

Review Comment:
   Fixed, thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org