You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2023/03/24 14:27:33 UTC

[camel] branch main updated (07e280d7dcc -> 9d59f96efe0)

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


    from 07e280d7dcc (chores) camel-route-parser: consolidate duplicated code
     new 2211a123350 (chores) camel-core-model: use builtin Java methods for data conversion
     new 2b9e648a0f4 (chores) camel-core: use builtin Java methods for data conversion
     new 81219b82e24 (chores) camel-support: use builtin Java methods for data conversion
     new 8842e21814e (chores) camel-util: use builtin Java methods for data conversion
     new 0c9c8fdc4cc (chores) camel-aws-xray: use builtin Java methods for data conversion
     new 80f2ae64608 (chores) camel-cm-sms: use builtin Java methods for data conversion
     new 9ea5390a481 (chores) camel-cxf: use builtin Java methods for data conversion
     new 7a990a6482a (chores) camel-file: use builtin Java methods for data conversion
     new e4ddf9eba18 (chores) camel-github: use builtin Java methods for data conversion
     new fbed324bf2c (chores) camel-http: use builtin Java methods for data conversion
     new 8f9100a68a8 (chores) camel-ironmq: use builtin Java methods for data conversion
     new c7ae20cfe2f (chores) camel-jaxb: use builtin Java methods for data conversion
     new cbcf796a53d (chores) camel-mllp: use builtin Java methods for data conversion
     new 9d65c1fd0c0 (chores) camel-netty-http: use builtin Java methods for data conversion
     new 986baae82c2 (chores) camel-paho: use builtin Java methods for data conversion
     new f0b5ee03ee1 (chores) camel-route-parser: use builtin Java methods for data conversion
     new 9d59f96efe0 (chores) camel-jbang: use builtin Java methods for data conversion

The 17 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/camel/parser/RouteBuilderParser.java  | 20 ++++++++++----------
 .../parser/helper/CamelJavaRestDslParserHelper.java  | 12 ++++++------
 .../parser/helper/CamelJavaTreeParserHelper.java     |  4 ++--
 .../camel/component/aws/xray/json/JsonParser.java    |  2 +-
 .../camel/component/cm/CMSenderOneMessageImpl.java   |  4 ++--
 .../cxf/jaxws/CxfConsumerPayloadXPathTest.java       |  2 +-
 .../org/apache/camel/component/file/GenericFile.java |  4 ++--
 .../github/services/MockPullRequestService.java      |  2 +-
 .../camel/component/http/HttpConcurrentTest.java     |  2 +-
 .../component/ironmq/IronMQBatchConsumerTest.java    |  2 +-
 .../ironmq/IronMQBatchDeleteConsumerTest.java        |  4 ++--
 .../camel/example/JaxbConcurrentDataFormatTest.java  |  4 ++--
 .../test/junit/rule/mllp/MllpServerResource.java     |  2 +-
 .../netty/http/DefaultNettySharedHttpServer.java     |  2 +-
 .../camel/component/paho/PahoComponentTest.java      |  2 +-
 .../java/org/apache/camel/model/RouteDefinition.java |  2 +-
 .../camel/model/rest/ResponseMessageDefinition.java  |  2 +-
 .../model/rest/RestConfigurationDefinition.java      |  2 +-
 .../impl/engine/CamelPostProcessorHelperTest.java    |  6 +++---
 .../processor/IdempotentConsumerConcurrentTest.java  |  2 +-
 .../org/apache/camel/support/CustomizersTest.java    |  9 ++++++---
 .../apache/camel/support/ClassicUuidGenerator.java   |  2 +-
 .../java/org/apache/camel/util/StringHelperTest.java |  2 +-
 .../core/commands/action/ActionBaseCommand.java      |  2 +-
 .../jbang/core/commands/action/CamelGCAction.java    |  2 +-
 .../core/commands/action/CamelReloadAction.java      |  2 +-
 .../core/commands/action/CamelResetStatsAction.java  |  2 +-
 .../jbang/core/commands/action/CamelRouteAction.java |  2 +-
 .../core/commands/action/CamelSourceAction.java      |  4 ++--
 .../jbang/core/commands/action/CamelSourceTop.java   |  4 ++--
 .../jbang/core/commands/action/CamelThreadDump.java  |  4 ++--
 .../dsl/jbang/core/commands/action/LoggerAction.java |  2 +-
 .../core/commands/action/RouteControllerAction.java  |  4 ++--
 .../core/commands/process/ProcessBaseCommand.java    |  2 +-
 34 files changed, 64 insertions(+), 61 deletions(-)


[camel] 06/17: (chores) camel-cm-sms: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 80f2ae646086889ef4bdec79438d8d378d60250d
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:02:28 2023 +0100

    (chores) camel-cm-sms: use builtin Java methods for data conversion
---
 .../java/org/apache/camel/component/cm/CMSenderOneMessageImpl.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/components/camel-cm-sms/src/main/java/org/apache/camel/component/cm/CMSenderOneMessageImpl.java b/components/camel-cm-sms/src/main/java/org/apache/camel/component/cm/CMSenderOneMessageImpl.java
index c6404bbfda4..f4634f05f6f 100644
--- a/components/camel-cm-sms/src/main/java/org/apache/camel/component/cm/CMSenderOneMessageImpl.java
+++ b/components/camel-cm-sms/src/main/java/org/apache/camel/component/cm/CMSenderOneMessageImpl.java
@@ -109,7 +109,7 @@ public class CMSenderOneMessageImpl implements CMSender {
             final Element authenticationElement = doc.createElement("AUTHENTICATION");
             final Element productTokenElement = doc.createElement("PRODUCTTOKEN");
             authenticationElement.appendChild(productTokenElement);
-            final Text productTokenValue = doc.createTextNode("" + productToken);
+            final Text productTokenValue = doc.createTextNode(productToken.toString());
             productTokenElement.appendChild(productTokenValue);
             root.appendChild(authenticationElement);
 
@@ -144,7 +144,7 @@ public class CMSenderOneMessageImpl implements CMSender {
             final String id = message.getIdAsString();
             if (id != null && !id.isEmpty()) {
                 final Element refElement = doc.createElement("REFERENCE");
-                refElement.appendChild(doc.createTextNode("" + message.getIdAsString()));
+                refElement.appendChild(doc.createTextNode(message.getIdAsString()));
                 msgElement.appendChild(refElement);
             }
 


[camel] 01/17: (chores) camel-core-model: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 2211a123350e9cb4b6a1d20d6c43b9415e163a60
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 13:47:46 2023 +0100

    (chores) camel-core-model: use builtin Java methods for data conversion
---
 .../src/main/java/org/apache/camel/model/RouteDefinition.java           | 2 +-
 .../java/org/apache/camel/model/rest/ResponseMessageDefinition.java     | 2 +-
 .../java/org/apache/camel/model/rest/RestConfigurationDefinition.java   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinition.java b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinition.java
index 0d12bd36912..d64b02a06f6 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinition.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinition.java
@@ -425,7 +425,7 @@ public class RouteDefinition extends OutputDefinition<RouteDefinition>
      * @return       the builder
      */
     public RouteDefinition delayer(long delay) {
-        setDelayer("" + delay);
+        setDelayer(Long.toString(delay));
         return this;
     }
 
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/rest/ResponseMessageDefinition.java b/core/camel-core-model/src/main/java/org/apache/camel/model/rest/ResponseMessageDefinition.java
index 244c8d2a0a8..ef7d72584d8 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/model/rest/ResponseMessageDefinition.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/model/rest/ResponseMessageDefinition.java
@@ -109,7 +109,7 @@ public class ResponseMessageDefinition {
      * The response code such as a HTTP status code
      */
     public ResponseMessageDefinition code(int code) {
-        setCode("" + code);
+        setCode(Integer.toString(code));
         return this;
     }
 
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestConfigurationDefinition.java b/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestConfigurationDefinition.java
index fda2e9158f2..e7a1d937c58 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestConfigurationDefinition.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/model/rest/RestConfigurationDefinition.java
@@ -538,7 +538,7 @@ public class RestConfigurationDefinition {
      * To specify the port number to use for the REST service
      */
     public RestConfigurationDefinition port(int port) {
-        setPort("" + port);
+        setPort(Integer.toString(port));
         return this;
     }
 


[camel] 13/17: (chores) camel-mllp: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit cbcf796a53d42f6a5ee71770aa3825dbda081cc9
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:07:56 2023 +0100

    (chores) camel-mllp: use builtin Java methods for data conversion
---
 .../java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java b/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java
index 363bb5d7740..d26bb11f8c2 100644
--- a/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java
+++ b/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java
@@ -562,7 +562,7 @@ public class MllpServerResource implements BeforeEachCallback, AfterEachCallback
         if (-1 != endOfMshSegment) {
             String mshSegment = hl7Message.substring(0, endOfMshSegment);
             char fieldSeparator = mshSegment.charAt(3);
-            String fieldSeparatorPattern = Pattern.quote("" + fieldSeparator);
+            String fieldSeparatorPattern = Pattern.quote(String.valueOf(fieldSeparator));
             String[] mshFields = mshSegment.split(fieldSeparatorPattern);
             if (mshFields.length == 0) {
                 log.error("Failed to split MSH Segment into fields");


[camel] 15/17: (chores) camel-paho: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 986baae82c22bf7a2f21f373689b04e2fdff8e71
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:08:55 2023 +0100

    (chores) camel-paho: use builtin Java methods for data conversion
---
 .../test/java/org/apache/camel/component/paho/PahoComponentTest.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java b/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
index f705df2a1ea..d3e96c7ca5b 100644
--- a/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
+++ b/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoComponentTest.java
@@ -77,7 +77,7 @@ public class PahoComponentTest extends PahoTestSupport {
         // Then
         assertEquals("/test/topic", endpoint.getTopic());
         assertEquals("sampleClient", endpoint.getConfiguration().getClientId());
-        assertEquals("" + service.serviceAddress(), endpoint.getConfiguration().getBrokerUrl());
+        assertEquals(service.serviceAddress(), endpoint.getConfiguration().getBrokerUrl());
         assertEquals(2, endpoint.getConfiguration().getQos());
         assertEquals(PahoPersistence.FILE, endpoint.getConfiguration().getPersistence());
     }


[camel] 04/17: (chores) camel-util: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 8842e21814efe96710f2d5008ba88b2d3e998e5d
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 13:51:02 2023 +0100

    (chores) camel-util: use builtin Java methods for data conversion
---
 .../src/test/java/org/apache/camel/util/StringHelperTest.java           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/camel-util/src/test/java/org/apache/camel/util/StringHelperTest.java b/core/camel-util/src/test/java/org/apache/camel/util/StringHelperTest.java
index 8f90d4688a9..70d6569ecc2 100644
--- a/core/camel-util/src/test/java/org/apache/camel/util/StringHelperTest.java
+++ b/core/camel-util/src/test/java/org/apache/camel/util/StringHelperTest.java
@@ -210,7 +210,7 @@ public class StringHelperTest {
         int count = StringHelper.countChar(value, ',') + 1;
         it = splitOnCharacterAsIterator(value, ',', count);
         for (int i = 0; i < 100; i++) {
-            assertEquals("" + i, it.next());
+            assertEquals(Integer.toString(i), it.next());
         }
         assertFalse(it.hasNext());
     }


[camel] 08/17: (chores) camel-file: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 7a990a6482a6f045db0108e807a645e25013ca70
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:03:47 2023 +0100

    (chores) camel-file: use builtin Java methods for data conversion
---
 .../src/main/java/org/apache/camel/component/file/GenericFile.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/components/camel-file/src/main/java/org/apache/camel/component/file/GenericFile.java b/components/camel-file/src/main/java/org/apache/camel/component/file/GenericFile.java
index 19b85360b28..03480973257 100644
--- a/components/camel-file/src/main/java/org/apache/camel/component/file/GenericFile.java
+++ b/components/camel-file/src/main/java/org/apache/camel/component/file/GenericFile.java
@@ -216,7 +216,7 @@ public class GenericFile<T> implements WrappedFile<T> {
         // Make sure the names is normalized.
         String newFileName = FileUtil.normalizePath(newName);
         String newEndpointPath = FileUtil.normalizePath(
-                endpointPath.endsWith("" + File.separatorChar) ? endpointPath : endpointPath + File.separatorChar);
+                endpointPath.endsWith(String.valueOf(File.separatorChar)) ? endpointPath : endpointPath + File.separatorChar);
 
         LOG.trace("Normalized endpointPath: {}", newEndpointPath);
         LOG.trace("Normalized newFileName: {}", newFileName);
@@ -230,7 +230,7 @@ public class GenericFile<T> implements WrappedFile<T> {
                 // use File.separatorChar as the normalizePath uses this as path
                 // separator so we should use the same
                 // in this logic here
-                if (newEndpointPath.endsWith("" + File.separatorChar)) {
+                if (newEndpointPath.endsWith(String.valueOf(File.separatorChar))) {
                     newFileName = StringHelper.after(newFileName, newEndpointPath);
                 } else {
                     newFileName = StringHelper.after(newFileName, newEndpointPath + File.separatorChar);


[camel] 05/17: (chores) camel-aws-xray: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 0c9c8fdc4cc1bd1f7a3ce5348585e50acf0017d0
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:02:07 2023 +0100

    (chores) camel-aws-xray: use builtin Java methods for data conversion
---
 .../test/java/org/apache/camel/component/aws/xray/json/JsonParser.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-aws/camel-aws-xray/src/test/java/org/apache/camel/component/aws/xray/json/JsonParser.java b/components/camel-aws/camel-aws-xray/src/test/java/org/apache/camel/component/aws/xray/json/JsonParser.java
index 7c165fa1cae..1d76f24750c 100644
--- a/components/camel-aws/camel-aws-xray/src/test/java/org/apache/camel/component/aws/xray/json/JsonParser.java
+++ b/components/camel-aws/camel-aws-xray/src/test/java/org/apache/camel/component/aws/xray/json/JsonParser.java
@@ -109,7 +109,7 @@ public final class JsonParser {
                             || ('"' == c && curToken.length() > 0 && curToken.charAt(curToken.length() - 1) != '\\')) {
                         inWord = !inWord;
                     }
-                    if (!inWord && !doNotIncludeSymbols.contains("" + c)) {
+                    if (!inWord && !doNotIncludeSymbols.contains(String.valueOf(c))) {
                         curToken.append(c);
                     } else if ('"' != c || (curToken.length() > 0 && curToken.charAt(curToken.length() - 1) == '\\')) {
                         curToken.append(c);


[camel] 03/17: (chores) camel-support: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 81219b82e24a880a0b7fdf1c37a56edc57025782
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 13:50:52 2023 +0100

    (chores) camel-support: use builtin Java methods for data conversion
---
 .../src/main/java/org/apache/camel/support/ClassicUuidGenerator.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/camel-support/src/main/java/org/apache/camel/support/ClassicUuidGenerator.java b/core/camel-support/src/main/java/org/apache/camel/support/ClassicUuidGenerator.java
index 8ea106c03d2..40b2185a507 100644
--- a/core/camel-support/src/main/java/org/apache/camel/support/ClassicUuidGenerator.java
+++ b/core/camel-support/src/main/java/org/apache/camel/support/ClassicUuidGenerator.java
@@ -82,7 +82,7 @@ public class ClassicUuidGenerator implements UuidGenerator {
             this.seed = prefix + UNIQUE_STUB + (instanceCount++) + "-";
             // let the ID be friendly for URL and file systems
             this.seed = generateSanitizedId(this.seed);
-            this.length = seed.length() + ("" + Long.MAX_VALUE).length();
+            this.length = seed.length() + (Long.toString(Long.MAX_VALUE)).length();
         }
     }
 


[camel] 10/17: (chores) camel-http: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit fbed324bf2c92b18db2fc146b904cdaa05f80d77
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:04:35 2023 +0100

    (chores) camel-http: use builtin Java methods for data conversion
---
 .../test/java/org/apache/camel/component/http/HttpConcurrentTest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-http/src/test/java/org/apache/camel/component/http/HttpConcurrentTest.java b/components/camel-http/src/test/java/org/apache/camel/component/http/HttpConcurrentTest.java
index 5250255b0ae..a90911968a4 100644
--- a/components/camel-http/src/test/java/org/apache/camel/component/http/HttpConcurrentTest.java
+++ b/components/camel-http/src/test/java/org/apache/camel/component/http/HttpConcurrentTest.java
@@ -54,7 +54,7 @@ public class HttpConcurrentTest extends BaseHttpTest {
                         // ignore
                     }
                     response.setCode(HttpStatus.SC_OK);
-                    response.setEntity(new StringEntity("" + counter.incrementAndGet()));
+                    response.setEntity(new StringEntity(Integer.toString(counter.incrementAndGet())));
                 }).create();
         localServer.start();
 


[camel] 17/17: (chores) camel-jbang: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 9d59f96efe0265ccd69b007223635175e0830540
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:10:37 2023 +0100

    (chores) camel-jbang: use builtin Java methods for data conversion
---
 .../camel/dsl/jbang/core/commands/action/ActionBaseCommand.java       | 2 +-
 .../apache/camel/dsl/jbang/core/commands/action/CamelGCAction.java    | 2 +-
 .../camel/dsl/jbang/core/commands/action/CamelReloadAction.java       | 2 +-
 .../camel/dsl/jbang/core/commands/action/CamelResetStatsAction.java   | 2 +-
 .../apache/camel/dsl/jbang/core/commands/action/CamelRouteAction.java | 2 +-
 .../camel/dsl/jbang/core/commands/action/CamelSourceAction.java       | 4 ++--
 .../apache/camel/dsl/jbang/core/commands/action/CamelSourceTop.java   | 4 ++--
 .../apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java  | 4 ++--
 .../org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java | 2 +-
 .../camel/dsl/jbang/core/commands/action/RouteControllerAction.java   | 4 ++--
 .../camel/dsl/jbang/core/commands/process/ProcessBaseCommand.java     | 2 +-
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/ActionBaseCommand.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/ActionBaseCommand.java
index ff2f019c13e..5a956eb4ecf 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/ActionBaseCommand.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/ActionBaseCommand.java
@@ -97,7 +97,7 @@ abstract class ActionBaseCommand extends CamelCommand {
 
     JsonObject loadStatus(long pid) {
         try {
-            File f = getStatusFile("" + pid);
+            File f = getStatusFile(Long.toString(pid));
             if (f != null) {
                 FileInputStream fis = new FileInputStream(f);
                 String text = IOHelper.loadText(fis);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelGCAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelGCAction.java
index a0ca44ab8ea..2d706c1db94 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelGCAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelGCAction.java
@@ -41,7 +41,7 @@ public class CamelGCAction extends ActionBaseCommand {
         for (long pid : pids) {
             JsonObject root = new JsonObject();
             root.put("action", "gc");
-            File f = getActionFile("" + pid);
+            File f = getActionFile(Long.toString(pid));
             IOHelper.writeText(root.toJson(), f);
         }
 
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelReloadAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelReloadAction.java
index 64e2aba6ee4..b7f347b46c4 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelReloadAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelReloadAction.java
@@ -41,7 +41,7 @@ public class CamelReloadAction extends ActionBaseCommand {
         for (long pid : pids) {
             JsonObject root = new JsonObject();
             root.put("action", "reload");
-            File f = getActionFile("" + pid);
+            File f = getActionFile(Long.toString(pid));
             IOHelper.writeText(root.toJson(), f);
         }
 
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelResetStatsAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelResetStatsAction.java
index 7e0751bd858..f680e90387b 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelResetStatsAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelResetStatsAction.java
@@ -41,7 +41,7 @@ public class CamelResetStatsAction extends ActionBaseCommand {
         for (long pid : pids) {
             JsonObject root = new JsonObject();
             root.put("action", "reset-stats");
-            File f = getActionFile("" + pid);
+            File f = getActionFile(Long.toString(pid));
             IOHelper.writeText(root.toJson(), f);
         }
 
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelRouteAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelRouteAction.java
index 7a85a7be2a3..a23d3602b6f 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelRouteAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelRouteAction.java
@@ -55,7 +55,7 @@ public abstract class CamelRouteAction extends ActionBaseCommand {
             JsonObject root = new JsonObject();
             root.put("action", "route");
             root.put("id", id);
-            File f = getActionFile("" + pid);
+            File f = getActionFile(Long.toString(pid));
             onAction(root);
             IOHelper.writeText(root.toJson(), f);
         }
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceAction.java
index ecdd9d443db..dc8cec880a2 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceAction.java
@@ -72,13 +72,13 @@ public class CamelSourceAction extends ActionBaseCommand {
         this.pid = pids.get(0);
 
         // ensure output file is deleted before executing action
-        File outputFile = getOutputFile("" + pid);
+        File outputFile = getOutputFile(Long.toString(pid));
         FileUtil.deleteFile(outputFile);
 
         JsonObject root = new JsonObject();
         root.put("action", "source");
         root.put("filter", "*");
-        File file = getActionFile("" + pid);
+        File file = getActionFile(Long.toString(pid));
         try {
             IOHelper.writeText(root.toJson(), file);
         } catch (Exception e) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceTop.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceTop.java
index b6d584a4630..a83eb250f0b 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceTop.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelSourceTop.java
@@ -68,12 +68,12 @@ public class CamelSourceTop extends ActionWatchCommand {
         this.pid = pids.get(0);
 
         // ensure output file is deleted before executing action
-        File outputFile = getOutputFile("" + pid);
+        File outputFile = getOutputFile(Long.toString(pid));
         FileUtil.deleteFile(outputFile);
 
         JsonObject root = new JsonObject();
         root.put("action", "top-processors");
-        File f = getActionFile("" + pid);
+        File f = getActionFile(Long.toString(pid));
         try {
             IOHelper.writeText(root.toJson(), f);
         } catch (Exception e) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java
index d47bc97359a..be551e12c61 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelThreadDump.java
@@ -99,12 +99,12 @@ public class CamelThreadDump extends ActionWatchCommand {
         this.pid = pids.get(0);
 
         // ensure output file is deleted before executing action
-        File outputFile = getOutputFile("" + pid);
+        File outputFile = getOutputFile(Long.toString(pid));
         FileUtil.deleteFile(outputFile);
 
         JsonObject root = new JsonObject();
         root.put("action", "thread-dump");
-        File f = getActionFile("" + pid);
+        File f = getActionFile(Long.toString(pid));
         try {
             IOHelper.writeText(root.toJson(), f);
         } catch (Exception e) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java
index 729e36ad88e..6a688a98d1e 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/LoggerAction.java
@@ -81,7 +81,7 @@ public class LoggerAction extends ActionBaseCommand {
         for (long pid : pids) {
             JsonObject root = new JsonObject();
             root.put("action", "logger");
-            File f = getActionFile("" + pid);
+            File f = getActionFile(Long.toString(pid));
             root.put("command", "set-logging-level");
             root.put("logger-name", logger);
             root.put("logging-level", loggingLevel);
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java
index 96e54d830eb..046e61242c3 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/RouteControllerAction.java
@@ -100,13 +100,13 @@ public class RouteControllerAction extends ActionWatchCommand {
         this.pid = pids.get(0);
 
         // ensure output file is deleted before executing action
-        File outputFile = getOutputFile("" + pid);
+        File outputFile = getOutputFile(Long.toString(pid));
         FileUtil.deleteFile(outputFile);
 
         JsonObject root = new JsonObject();
         root.put("action", "route-controller");
         root.put("stacktrace", trace ? "true" : "false");
-        File f = getActionFile("" + pid);
+        File f = getActionFile(Long.toString(pid));
         try {
             IOHelper.writeText(root.toJson(), f);
         } catch (Exception e) {
diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ProcessBaseCommand.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ProcessBaseCommand.java
index 33623ea384b..562709700f4 100644
--- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ProcessBaseCommand.java
+++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ProcessBaseCommand.java
@@ -98,7 +98,7 @@ abstract class ProcessBaseCommand extends CamelCommand {
 
     JsonObject loadStatus(long pid) {
         try {
-            File f = getStatusFile("" + pid);
+            File f = getStatusFile(Long.toString(pid));
             if (f != null && f.exists()) {
                 FileInputStream fis = new FileInputStream(f);
                 String text = IOHelper.loadText(fis);


[camel] 14/17: (chores) camel-netty-http: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 9d65c1fd0c09c0721a96b8515e830c25578989dc
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:08:27 2023 +0100

    (chores) camel-netty-http: use builtin Java methods for data conversion
---
 .../apache/camel/component/netty/http/DefaultNettySharedHttpServer.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettySharedHttpServer.java b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettySharedHttpServer.java
index 10ae922e196..a47b8c70bff 100644
--- a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettySharedHttpServer.java
+++ b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettySharedHttpServer.java
@@ -121,7 +121,7 @@ public class DefaultNettySharedHttpServer extends ServiceSupport implements Nett
                 = new HttpServerSharedInitializerFactory(configuration, channelFactory, camelContext);
 
         // thread factory and pattern
-        String port = Matcher.quoteReplacement("" + configuration.getPort());
+        String port = Matcher.quoteReplacement(Integer.toString(configuration.getPort()));
         String pattern = threadPattern;
         pattern = pattern.replaceFirst("#port#", port);
         ThreadFactory tf = new CamelThreadFactory(pattern, "NettySharedHttpServer", true);


[camel] 09/17: (chores) camel-github: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit e4ddf9eba1830bac390cbc55ceefd4d37e0e7e80
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:04:06 2023 +0100

    (chores) camel-github: use builtin Java methods for data conversion
---
 .../apache/camel/component/github/services/MockPullRequestService.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-github/src/test/java/org/apache/camel/component/github/services/MockPullRequestService.java b/components/camel-github/src/test/java/org/apache/camel/component/github/services/MockPullRequestService.java
index e0f6f205570..af06c0eddf5 100644
--- a/components/camel-github/src/test/java/org/apache/camel/component/github/services/MockPullRequestService.java
+++ b/components/camel-github/src/test/java/org/apache/camel/component/github/services/MockPullRequestService.java
@@ -66,7 +66,7 @@ public class MockPullRequestService extends PullRequestService {
 
         User author = createAuthor();
         commitComment.setUser(author);
-        commitComment.setCommitId("" + pullRequestId);
+        commitComment.setCommitId(Long.toString(pullRequestId));
         commitComment.setId(commentId.getAndIncrement());
         commitComment.setBody(bodyText);
         commitComment.setBodyText(bodyText);


[camel] 16/17: (chores) camel-route-parser: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit f0b5ee03ee1ab64f87e131c6357b3d23919c1762
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:09:19 2023 +0100

    (chores) camel-route-parser: use builtin Java methods for data conversion
---
 .../org/apache/camel/parser/RouteBuilderParser.java  | 20 ++++++++++----------
 .../parser/helper/CamelJavaRestDslParserHelper.java  | 12 ++++++------
 .../parser/helper/CamelJavaTreeParserHelper.java     |  4 ++--
 3 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/RouteBuilderParser.java b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/RouteBuilderParser.java
index 18fe868d61e..c583f6570c0 100644
--- a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/RouteBuilderParser.java
+++ b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/RouteBuilderParser.java
@@ -155,11 +155,11 @@ public final class RouteBuilderParser {
                     int len = ((ASTNode) internal).getLength();
                     int line = findLineNumber(clazz.toUnformattedString(), pos);
                     if (line > -1) {
-                        detail.setLineNumber("" + line);
+                        detail.setLineNumber(Integer.toString(line));
                     }
                     int endLine = findLineNumber(clazz.toUnformattedString(), pos + len);
                     if (endLine > -1) {
-                        detail.setLineNumberEnd("" + endLine);
+                        detail.setLineNumberEnd(Integer.toString(endLine));
                     }
                     detail.setAbsolutePosition(pos);
                     int linePos = findLinePosition(clazz.toUnformattedString(), pos);
@@ -242,11 +242,11 @@ public final class RouteBuilderParser {
         detail.setEndpointUri(result.getElement());
         int line = findLineNumber(clazz.toUnformattedString(), result.getPosition());
         if (line > -1) {
-            detail.setLineNumber("" + line);
+            detail.setLineNumber(Integer.toString(line));
         }
         int lineEnd = findLineNumber(clazz.toUnformattedString(), result.getPosition() + result.getLength());
         if (lineEnd > -1) {
-            detail.setLineNumberEnd("" + lineEnd);
+            detail.setLineNumberEnd(Integer.toString(lineEnd));
         }
         detail.setAbsolutePosition(result.getPosition());
         int linePos = findLinePosition(clazz.toUnformattedString(), result.getPosition());
@@ -289,11 +289,11 @@ public final class RouteBuilderParser {
                     detail.setMethodName("configure");
                     int line = findLineNumber(clazz.toUnformattedString(), result.getPosition());
                     if (line > -1) {
-                        detail.setLineNumber("" + line);
+                        detail.setLineNumber(Integer.toString(line));
                     }
                     int endLine = findLineNumber(clazz.toUnformattedString(), result.getPosition() + result.getLength());
                     if (endLine > -1) {
-                        detail.setLineNumberEnd("" + endLine);
+                        detail.setLineNumberEnd(Integer.toString(endLine));
                     }
                     detail.setAbsolutePosition(result.getPosition());
                     int linePos = findLinePosition(clazz.toUnformattedString(), result.getPosition());
@@ -337,11 +337,11 @@ public final class RouteBuilderParser {
                     detail.setMethodName("configure");
                     int line = findLineNumber(clazz.toUnformattedString(), result.getPosition());
                     if (line > -1) {
-                        detail.setLineNumber("" + line);
+                        detail.setLineNumber(Integer.toString(line));
                     }
                     int endLine = findLineNumber(clazz.toUnformattedString(), result.getPosition() + result.getLength());
                     if (endLine > -1) {
-                        detail.setLineNumberEnd("" + endLine);
+                        detail.setLineNumberEnd(Integer.toString(endLine));
                     }
                     detail.setAbsolutePosition(result.getPosition());
                     int linePos = findLinePosition(clazz.toUnformattedString(), result.getPosition());
@@ -387,11 +387,11 @@ public final class RouteBuilderParser {
                     detail.setMethodName("configure");
                     int line = findLineNumber(clazz.toUnformattedString(), result.getPosition());
                     if (line > -1) {
-                        detail.setLineNumber("" + line);
+                        detail.setLineNumber(Integer.toString(line));
                     }
                     int endLine = findLineNumber(clazz.toUnformattedString(), result.getPosition() + result.getLength());
                     if (endLine > -1) {
-                        detail.setLineNumberEnd("" + endLine);
+                        detail.setLineNumberEnd(Integer.toString(endLine));
                     }
                     detail.setRouteId(result.getElement());
 
diff --git a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java
index e4d8e7a14b9..b33ae36c7d2 100644
--- a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java
+++ b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaRestDslParserHelper.java
@@ -83,12 +83,12 @@ public final class CamelJavaRestDslParserHelper {
                             int pos = exp.getStartPosition();
                             int line = findLineNumber(fullyQualifiedFileName, pos);
                             if (line > -1) {
-                                node.setLineNumber("" + line);
+                                node.setLineNumber(Integer.toString(line));
                             }
                             pos = exp.getStartPosition() + exp.getLength();
                             line = findLineNumber(fullyQualifiedFileName, pos);
                             if (line > -1) {
-                                node.setLineNumberEnd("" + line);
+                                node.setLineNumberEnd(Integer.toString(line));
                             }
                             node.setFileName(fullyQualifiedFileName);
                             node.setClassName(clazz.getQualifiedName());
@@ -128,12 +128,12 @@ public final class CamelJavaRestDslParserHelper {
                             int pos = exp.getStartPosition();
                             int line = findLineNumber(fullyQualifiedFileName, pos);
                             if (line > -1) {
-                                node.setLineNumber("" + line);
+                                node.setLineNumber(Integer.toString(line));
                             }
                             pos = exp.getStartPosition() + exp.getLength();
                             line = findLineNumber(fullyQualifiedFileName, pos);
                             if (line > -1) {
-                                node.setLineNumberEnd("" + line);
+                                node.setLineNumberEnd(Integer.toString(line));
                             }
                             node.setFileName(fullyQualifiedFileName);
                             node.setClassName(clazz.getQualifiedName());
@@ -242,7 +242,7 @@ public final class CamelJavaRestDslParserHelper {
             int pos = mi.getStartPosition() + mi.getLength();
             int line = findLineNumber(fullyQualifiedFileName, pos);
             if (line > -1) {
-                node.setLineNumberEnd("" + line);
+                node.setLineNumberEnd(Integer.toString(line));
             }
         }
 
@@ -320,7 +320,7 @@ public final class CamelJavaRestDslParserHelper {
             int pos = mi.getStartPosition() + mi.getLength();
             int line = findLineNumber(fullyQualifiedFileName, pos);
             if (line > -1) {
-                node.setLineNumberEnd("" + line);
+                node.setLineNumberEnd(Integer.toString(line));
             }
         }
 
diff --git a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java
index 04e10cdbd1d..fda54847f7d 100644
--- a/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java
+++ b/catalog/camel-route-parser/src/main/java/org/apache/camel/parser/helper/CamelJavaTreeParserHelper.java
@@ -246,12 +246,12 @@ public final class CamelJavaTreeParserHelper {
             int pos = mi.getName().getStartPosition();
             int line = findLineNumber(fullyQualifiedFileName, pos);
             if (line > -1) {
-                newNode.setLineNumber("" + line);
+                newNode.setLineNumber(Integer.toString(line));
             }
             pos = mi.getName().getStartPosition() + mi.getName().getLength();
             line = findLineNumber(fullyQualifiedFileName, pos);
             if (line > -1) {
-                newNode.setLineNumberEnd("" + line);
+                newNode.setLineNumberEnd(Integer.toString(line));
             }
             newNode.setFileName(fullyQualifiedFileName);
             newNode.setClassName(clazz.getQualifiedName());


[camel] 02/17: (chores) camel-core: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 2b9e648a0f4222649ad5a0fe9d940674f7e5c53c
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 13:50:11 2023 +0100

    (chores) camel-core: use builtin Java methods for data conversion
---
 .../apache/camel/impl/engine/CamelPostProcessorHelperTest.java   | 6 +++---
 .../apache/camel/processor/IdempotentConsumerConcurrentTest.java | 2 +-
 .../src/test/java/org/apache/camel/support/CustomizersTest.java  | 9 ++++++---
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/core/camel-core/src/test/java/org/apache/camel/impl/engine/CamelPostProcessorHelperTest.java b/core/camel-core/src/test/java/org/apache/camel/impl/engine/CamelPostProcessorHelperTest.java
index 0781641f881..c063641c9e7 100644
--- a/core/camel-core/src/test/java/org/apache/camel/impl/engine/CamelPostProcessorHelperTest.java
+++ b/core/camel-core/src/test/java/org/apache/camel/impl/engine/CamelPostProcessorHelperTest.java
@@ -375,7 +375,7 @@ public class CamelPostProcessorHelperTest extends ContextTestSupport {
         PropertyInject propertyInject = field.getAnnotation(PropertyInject.class);
         Class<?> type = field.getType();
         Object value = helper.getInjectionPropertyValue(type, propertyInject.value(), "", "timeout", bean, "foo");
-        assertEquals(Integer.valueOf("2000"), (Object) Integer.valueOf("" + value));
+        assertEquals(Integer.valueOf(2000), (Object) Integer.valueOf(String.valueOf(value)));
 
         field = bean.getClass().getField("greeting");
         propertyInject = field.getAnnotation(PropertyInject.class);
@@ -396,7 +396,7 @@ public class CamelPostProcessorHelperTest extends ContextTestSupport {
         PropertyInject propertyInject = field.getAnnotation(PropertyInject.class);
         Class<?> type = field.getType();
         Object value = helper.getInjectionPropertyValue(type, propertyInject.value(), "5000", "timeout", bean, "foo");
-        assertEquals(Integer.valueOf("5000"), (Object) Integer.valueOf("" + value));
+        assertEquals(Integer.valueOf(5000), (Object) Integer.valueOf(String.valueOf(value)));
 
         field = bean.getClass().getField("greeting");
         propertyInject = field.getAnnotation(PropertyInject.class);
@@ -418,7 +418,7 @@ public class CamelPostProcessorHelperTest extends ContextTestSupport {
         PropertyInject propertyInject = method.getAnnotation(PropertyInject.class);
         Class<?> type = method.getParameterTypes()[0];
         Object value = helper.getInjectionPropertyValue(type, propertyInject.value(), "", "timeout", bean, "foo");
-        assertEquals(Integer.valueOf("2000"), (Object) Integer.valueOf("" + value));
+        assertEquals(Integer.valueOf(2000), (Object) Integer.valueOf(String.valueOf(value)));
 
         method = bean.getClass().getMethod("setGreeting", String.class);
         propertyInject = method.getAnnotation(PropertyInject.class);
diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/IdempotentConsumerConcurrentTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/IdempotentConsumerConcurrentTest.java
index 0f56cc7a1ba..7a6080ed4a5 100644
--- a/core/camel-core/src/test/java/org/apache/camel/processor/IdempotentConsumerConcurrentTest.java
+++ b/core/camel-core/src/test/java/org/apache/camel/processor/IdempotentConsumerConcurrentTest.java
@@ -167,7 +167,7 @@ public class IdempotentConsumerConcurrentTest extends ContextTestSupport {
                 public void run() {
                     try {
                         for (int j = 0; j < loopCount; j++) {
-                            sendMessage("" + j, "multithreadedTest" + j);
+                            sendMessage(String.valueOf(j), "multithreadedTest" + j);
                         }
                     } catch (Throwable e) {
                         LOG.error("Failed to send message: {}", e.getMessage(), e);
diff --git a/core/camel-core/src/test/java/org/apache/camel/support/CustomizersTest.java b/core/camel-core/src/test/java/org/apache/camel/support/CustomizersTest.java
index 39d6dc8549a..ec590239e92 100644
--- a/core/camel-core/src/test/java/org/apache/camel/support/CustomizersTest.java
+++ b/core/camel-core/src/test/java/org/apache/camel/support/CustomizersTest.java
@@ -321,7 +321,8 @@ public class CustomizersTest {
                 new TokenizeLanguage());
         context.getCamelContextExtension().getRegistry().bind(
                 "tokenize-customizer",
-                LanguageCustomizer.forType(TokenizeLanguage.class, target -> target.setGroup("" + counter.incrementAndGet())));
+                LanguageCustomizer.forType(TokenizeLanguage.class,
+                        target -> target.setGroup(Integer.toString(counter.incrementAndGet()))));
 
         Language l1 = context.resolveLanguage("tokenize");
         assertTrue(l1 instanceof TokenizeLanguage);
@@ -343,7 +344,8 @@ public class CustomizersTest {
         DefaultCamelContext context = new DefaultCamelContext();
         context.getCamelContextExtension().getRegistry().bind(
                 "tokenize-customizer",
-                LanguageCustomizer.forType(TokenizeLanguage.class, target -> target.setGroup("" + counter.incrementAndGet())));
+                LanguageCustomizer.forType(TokenizeLanguage.class,
+                        target -> target.setGroup(Integer.toString(counter.incrementAndGet()))));
 
         // singleton language so its customized once
         Language l1 = context.resolveLanguage("tokenize");
@@ -367,7 +369,8 @@ public class CustomizersTest {
                 LanguageCustomizer.Policy.none());
         context.getCamelContextExtension().getRegistry().bind(
                 "tokenize-customizer",
-                LanguageCustomizer.forType(TokenizeLanguage.class, target -> target.setGroup("" + counter.incrementAndGet())));
+                LanguageCustomizer.forType(TokenizeLanguage.class,
+                        target -> target.setGroup(Integer.toString(counter.incrementAndGet()))));
 
         // singleton language so its customized once
         Language l1 = context.resolveLanguage("tokenize");


[camel] 11/17: (chores) camel-ironmq: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 8f9100a68a836e8511cf449004fec1768c04c53f
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:04:52 2023 +0100

    (chores) camel-ironmq: use builtin Java methods for data conversion
---
 .../org/apache/camel/component/ironmq/IronMQBatchConsumerTest.java    | 2 +-
 .../apache/camel/component/ironmq/IronMQBatchDeleteConsumerTest.java  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchConsumerTest.java b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchConsumerTest.java
index 65ed57aaed4..8e79697e21b 100644
--- a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchConsumerTest.java
+++ b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchConsumerTest.java
@@ -36,7 +36,7 @@ public class IronMQBatchConsumerTest extends CamelTestSupport {
         for (int counter = 0; counter <= 5; counter++) {
             Message message = new Message();
             message.setBody("{\"body\": \"Message " + counter + "\"}");
-            message.setId("" + counter);
+            message.setId(Integer.toString(counter));
             ((MockQueue) endpoint.getClient().queue("testqueue")).add(message);
         }
 
diff --git a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchDeleteConsumerTest.java b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchDeleteConsumerTest.java
index 80248f352e1..da547d8ce77 100644
--- a/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchDeleteConsumerTest.java
+++ b/components/camel-ironmq/src/test/java/org/apache/camel/component/ironmq/IronMQBatchDeleteConsumerTest.java
@@ -37,8 +37,8 @@ public class IronMQBatchDeleteConsumerTest extends CamelTestSupport {
         for (int counter = 0; counter <= 5; counter++) {
             Message message = new Message();
             message.setBody("{\"body\": \"Message " + counter + "\"}");
-            message.setId("" + counter);
-            message.setReservationId("" + counter);
+            message.setId(Integer.toString(counter));
+            message.setReservationId(Integer.toString(counter));
             ((MockQueue) endpoint.getClient().queue("testqueue22")).add(message);
         }
 


[camel] 07/17: (chores) camel-cxf: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 9ea5390a481d077930086b1dd5f74937df791cdf
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:03:40 2023 +0100

    (chores) camel-cxf: use builtin Java methods for data conversion
---
 .../apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java b/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
index 48e475ab789..5f98ff022a9 100644
--- a/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
+++ b/components/camel-cxf/camel-cxf-soap/src/test/java/org/apache/camel/component/cxf/jaxws/CxfConsumerPayloadXPathTest.java
@@ -226,7 +226,7 @@ public class CxfConsumerPayloadXPathTest extends CamelTestSupport {
 
         //check for data loss in received input (after xpath)
         String headerSize = exchgOut.getMessage().getHeader(HEADER_SIZE, String.class);
-        assertEquals("" + repeat, headerSize);
+        assertEquals(Integer.toString(repeat), headerSize);
 
         assertTrue(result.length() > repeat, "dataloss in output occurred");
 


[camel] 12/17: (chores) camel-jaxb: use builtin Java methods for data conversion

Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit c7ae20cfe2f203ee34bce0ca5619060b9bfcab2d
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Fri Mar 24 14:05:14 2023 +0100

    (chores) camel-jaxb: use builtin Java methods for data conversion
---
 .../java/org/apache/camel/example/JaxbConcurrentDataFormatTest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/components/camel-jaxb/src/test/java/org/apache/camel/example/JaxbConcurrentDataFormatTest.java b/components/camel-jaxb/src/test/java/org/apache/camel/example/JaxbConcurrentDataFormatTest.java
index 375c68c209a..7f65a70f266 100644
--- a/components/camel-jaxb/src/test/java/org/apache/camel/example/JaxbConcurrentDataFormatTest.java
+++ b/components/camel-jaxb/src/test/java/org/apache/camel/example/JaxbConcurrentDataFormatTest.java
@@ -52,8 +52,8 @@ public class JaxbConcurrentDataFormatTest extends CamelTestSupport {
                 public Object call() {
                     PurchaseOrder bean = new PurchaseOrder();
                     bean.setName("Beer");
-                    bean.setAmount(Double.valueOf("" + index));
-                    bean.setPrice(Double.valueOf("" + index) * 2);
+                    bean.setAmount(Double.valueOf(index));
+                    bean.setPrice(Double.valueOf(index) * 2);
 
                     template.sendBody("direct:start", bean);
                     return null;